Feature #7525: Report volume sizes via facter - Foreman

Custom queries

3.10.0 release DONE
3.10.0 release TODO
3.11.0 release DONE
3.11.0 release TODO
3.8.1 release DONE
3.8.1 release TODO
3.9.2 release DONE
3.9.2 release TODO
All bugs by votes
All issues closed in the last 3 weeks
Easy and Trivial Issues
Easy Issues (only)
Foreman - new open issues in last 10 days
Good first issues - Foreman core
high prio open bugs
Host registration [open]
Mine
My issues closed in the last 3 weeks
old bugs
Open with target version set (aka blockers)
registration
taken-none
Team Atlas untriaged bugs
templates
Trivial Issues
Untriaged and opened in the past two weeks

Actions

Copy link

Feature #7525

closed

Report volume sizes via facter

Added by Lukas Zapletal over 9 years ago. Updated almost 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Lukas Zapletal

Category:

Importers

Target version:

1.7.1

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/1854

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

We should report volume sizes similar way as facter does on provisioned systems. Discovery only reports blockdevice_vda_vendor and blockdevices list, but not blockdevice_vda_size.

When running facter manually as root, I see it. We need to raise foreman-proxy privileges for this perhaps.

Related issues 2 (0 open — 2 closed)

Related to Foreman - Feature #4528: Support Facter 2 structured facts

Closed

Dominic Cleal

03/03/2014

Actions

Related to Discovery - Tracker #8332: [Discovery 2.0] Usability alignment and autoprovisioning

Resolved

11/10/2014

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Ohad Levy over 9 years ago

Lukas Zapletal wrote:

When running facter manually as root, I see it. We need to raise foreman-proxy privileges for this perhaps.

run it with sudo maybe?

Actions

Copy link

Updated by Lukas Zapletal over 9 years ago

I was thinking suid... But then I relized this is discover-host.rb script which calls Facter via API. Not sure if we want to run the whole service as root... :-(

Actions

Copy link

Updated by Dominic Cleal over 9 years ago

Target version changed from 1.7.3 to 1.7.2

Actions

Copy link

Updated by Lukas Zapletal over 9 years ago

Status changed from New to Assigned

Ok its misbehavior of Foreman, we currently drop all facts which are non-string:

https://github.com/theforeman/foreman/blob/develop/app/services/fact_importer.rb#L80-L82

Actions

Copy link

Updated by Lukas Zapletal over 9 years ago

Related to Feature #4528: Support Facter 2 structured facts added

Actions

Copy link

Updated by Lukas Zapletal over 9 years ago

Ok so support for non-string values was added in Facter 2.0.

https://docs.puppetlabs.com/facter/2.0/release_notes.html#more-return-types-and-structured-facts

I will create a patch that will at least prevent from failing, so all of the types (Integer, Float, TrueClass, FalseClass, NilClass, String, Array, Hash) will be converted via to_s. Raising new feature request that should add proper support in reports (maybe to convert this into JSON).

Actions

Copy link

Updated by Lukas Zapletal over 9 years ago

So the issue linked already contains the request, I am going to convert this to string for the purpose of this bug and we will perhaps extend this later.

Actions

Copy link