ForemanChef's code "just works" for Salt's structured facts as well (after plainifying). It would be awesome to have a nested fact importer in Core that could just take the hash.

Let's merge it into core :-) Note that facts should still be scoped by name so we should add ForemanSalt::FactImporter inheriting from ForemanChef::FactImporter or ideally extract the generic part to some new NestedFactImporter class and let inherit both from it. Important methods that would remain importer specific: fact_name_class and support_background. Importer from ForemanChef is also lacking tests at the moment so it should be covered first.

Guys I need to get some integers in (discovery, hard disk volume sizes), can I post a patch to simply convert the number to string? See the referenced issue.

For the record, I filed a PR to convert non-string values to strings so it prevents from failure. We might want to do something smarter than this in this ticket, but since Staypuft is blocked by this I propose this solution: https://github.com/theforeman/foreman_discovery/pull/90

Bumping up the priority a bit, if this is implemented, our Discovery rule engine is much more powerful.

I just smacked into this in 1.6.3. Not even string structured facts are queryable via the gui.

This has been open for sometime and puppet has really pushed to using structured data facts more often, within their future parser it makes things much easier. Hope this is included very soon as hashes and arrays are fairly common and should be supported

Hello,

can anyone tell me when Foreman is able to manage facter 2 array/hash values ?
Is it on the roadmap ?

Would be nice if someone can update this issue

Thanks

Any update? Not having structured facts in foreman is getting to be a big hassle to get around. Would be nice to get an update, its been almost a year. Thanks.

Doesn't the foreman_ansible implementation by @dLobatog have nice structured facts already? It might be possible to use that same code?

Yup - it's also partly taken from Salt so hopefully we can provide this from core to all plugins.

Tickets relating to handling of non-structured, non-string facts (ints, bools) which are mentioned above:

• #7525 changed the importer to handle non-string facts by converting their values to strings, this helps notably with integer facts.
• #11150 changed fact searching to support integer comparisons, since Foreman stores integers as strings internally.
• I don't propose changing the storage of non-string facts in Foreman, it's sufficient to store them as strings and convert them when used (e.g. when searching).

Tickets relating to handling of array values:

• #15522 filed to enable storage of multiple fact values for arrays, instead of storing them as a string (e.g. ["a", "b"])

Tickets relating to handling of structured/nested/hash facts:

• #3339 added support for structured facts - that is, facts whose value is a hash of more facts
• This ticket will be used only to update the Puppet fact importer to store structured facts/hashes of facts.