Bug #11282: search on numeric facts is broken if using "~". - Foreman

Custom queries

3.10.0 release DONE
3.10.0 release TODO
3.11.0 release DONE
3.11.0 release TODO
3.8.1 release DONE
3.8.1 release TODO
3.9.2 release DONE
3.9.2 release TODO
All bugs by votes
All issues closed in the last 3 weeks
Easy and Trivial Issues
Easy Issues (only)
Foreman - new open issues in last 10 days
Good first issues - Foreman core
high prio open bugs
Host registration [open]
Mine
My issues closed in the last 3 weeks
old bugs
Open with target version set (aka blockers)
registration
taken-none
Team Atlas untriaged bugs
templates
Trivial Issues
Untriaged and opened in the past two weeks

Actions

Copy link

Bug #11282

closed

search on numeric facts is broken if using "~".

Added by Amir Fefer over 8 years ago. Updated almost 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Imri Zvik

Category:

Facts

Target version:

1.10.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/2626

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

When trying to search a numeric value fact and using operator '~' there a 500 error:
"PG::UndefinedFunction: ERROR: operator does not exist: numeric ~~* integer
LINE 1: ... E'^\\d+$' AND CAST ILIKE 0)) ...
^
HINT: No operator matches the given name and argument type(s). You might need to add explicit type casts."

recreate:
search- facts.uptime_days ~ 0

Related issues 1 (0 open — 1 closed)

Related to Foreman - Feature #11150: Allow searching of facts as types other than string

Closed

Imri Zvik

07/19/2015

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Dominic Cleal over 8 years ago

Related to Feature #11150: Allow searching of facts as types other than string added

Actions

Copy link

Updated by Dominic Cleal over 8 years ago

translation missing: en.field_release set to 63

Actions

Copy link

Updated by Imri Zvik over 8 years ago

Excluding the LIKE operator for PG in cast_facts solved this issue.
i.e.
instead of:
elsif (is_int && is_pg)

do:
elsif (is_int && is_pg && operator !~ /LIKE/i)

Dominic, if it sounds like an acceptable solution to you, I will open a PR.

Actions

Copy link

Updated by Ohad Levy over 8 years ago

Imri Zvik wrote:

Excluding the LIKE operator for PG in cast_facts solved this issue.
i.e.
instead of:
elsif (is_int && is_pg)

do:
elsif (is_int && is_pg && operator !~ /LIKE/i)

Dominic, if it sounds like an acceptable solution to you, I will open a PR.

I would suggest to open a PR and make sure you add the case mention here (and maybe others?) as a test?

thanks!

Actions

Copy link

Updated by Imri Zvik over 8 years ago

Ohad Levy wrote:

Imri Zvik wrote:

Excluding the LIKE operator for PG in cast_facts solved this issue.
i.e.
instead of:
elsif (is_int && is_pg)

do:
elsif (is_int && is_pg && operator !~ /LIKE/i)

Dominic, if it sounds like an acceptable solution to you, I will open a PR.

I would suggest to open a PR and make sure you add the case mention here (and maybe others?) as a test?

thanks!

Already did in my fork ;)
I will open a PR tomorrow.

Actions

Copy link

Updated by The Foreman Bot over 8 years ago

Status changed from New to Ready For Testing
Pull request https://github.com/theforeman/foreman/pull/2622 added
Pull request deleted ()

Actions

Copy link

Updated by Dominic Cleal over 8 years ago

Status changed from Ready For Testing to New
Pull request added
Pull request deleted (~~https://github.com/theforeman/foreman/pull/2622~~)