Bug #8133: template diffs don't get displayed anymore - Foreman

Custom queries

3.10.0 release DONE
3.10.0 release TODO
3.11.0 release DONE
3.11.0 release TODO
3.8.1 release DONE
3.8.1 release TODO
3.9.2 release DONE
3.9.2 release TODO
All bugs by votes
All issues closed in the last 3 weeks
Easy and Trivial Issues
Easy Issues (only)
Foreman - new open issues in last 10 days
Good first issues - Foreman core
high prio open bugs
Host registration [open]
Mine
My issues closed in the last 3 weeks
old bugs
Open with target version set (aka blockers)
registration
taken-none
Team Atlas untriaged bugs
templates
Trivial Issues
Untriaged and opened in the past two weeks

Actions

Copy link

Bug #8133

closed

template diffs don't get displayed anymore

Added by Anonymous over 9 years ago. Updated almost 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Dominic Cleal

Category:

Web Interface

Target version:

1.7.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/1886

Fixed in Releases:

Found in Releases:

Nightly

Red Hat JIRA:

Description

After changing the content of a template, the event is still visible in the audit logs, clicking it and looking at "Template Diff", "No changes" is always displayed. This can also be seen in 1.6.1.

Related issues 1 (0 open — 1 closed)

Related to Foreman - Bug #7483: CVE-2014-3653 - Provisioning Templates Preview mode strips out text like <<FOO

Closed

Aaron Stone

09/16/2014

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Anonymous over 9 years ago

Related to Bug #7483: CVE-2014-3653 - Provisioning Templates Preview mode strips out text like <<FOO added

Actions

Copy link

Updated by Anonymous over 9 years ago

I suspect the fix for #7483 introduced that problem.

Actions

Copy link

Updated by Dominic Cleal over 9 years ago

Status changed from New to Assigned
Assignee set to Dominic Cleal
Target version set to 1.7.2

Actions

Copy link

Updated by The Foreman Bot over 9 years ago

Status changed from Assigned to Ready For Testing
Pull request https://github.com/theforeman/foreman/pull/1886 added
Pull request deleted ()

Actions

Copy link

Updated by Daniel Lobato Garcia over 9 years ago

translation missing: en.field_release set to 21

Actions

Copy link

Updated by Dominic Cleal over 9 years ago

Status changed from Ready For Testing to Closed
% Done changed from 0 to 100

Applied in changeset ebf335e0d936be20e93e7b76217e46c813bfa548.

Actions

Copy link

Updated by Pablo Escobar over 9 years ago

I have manually applied this patch to my 1.6.1 installation and I found a weird behaviour when using firefox.

When I click in the "show diff" link two new tabs are open in firefox. In both tabs the diff is shown correctly but I alwasy get two new tabs.

I have seem the same behaviour in Firefox 33.0 (Linux) and Firefox 32.0.3 (Mac)

When using chrome in Linux or Mac I don't see this problem. Just one tab is created.

Actions

Copy link

Updated by Pablo Escobar over 9 years ago

I just realized that in chrome I was not observing this behaviour because of the pop-up blocker. When I disable the pop-up blocker in chrome I also get two new browser windows when clicking in "show diff"

Actions

Copy link