Project

General

Profile

Actions
Copy link

Refactor #5936

closed

Unnecessary call to FactName.maximum slows down ENC

Added by Daniel Lobato Garcia almost 10 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Daniel Lobato Garcia
Category:
External Nodes
Target version:
1.5.1
Difficulty:
Triaged:
Bugzilla link:
1107671
Pull request:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

As explained here: https://github.com/theforeman/foreman/pull/1477

The query "SELECT MAX AS maximum_id, name AS name FROM `fact_names` GROUP BY name ORDER BY fact_names.name" needs to be called only when there are facts to create. Calling it every time slows down every ENC call, especially when the fact_names table is large.

Actions
Copy link

Also available in: Atom PDF