Bug #3089
closed
Updating settings causes settings page to load again within the page
Added by Dominic Cleal over 10 years ago.
Updated over 10 years ago.
Description
Since #2969, updating a setting via the UI causes the request to be redirected back to the index on success and the settings page gets loaded within the settings page again, causing a huge mess in the UI.
Looks like this happens because process_response in application_controller had its JSON handling removed, and this is one instance where we legitimately perform model updates using JSON. Previously, it would just render the object.
- Related to Feature #2969: remove all legacy api code in UI controllers added
- Has duplicate Bug #3100: Saving sso_signo in Settings/Auth returns whole foreman page instead of json partial added
- Status changed from New to Assigned
- Assignee set to Joseph Magen
- Status changed from Assigned to Ready For Testing
- Priority changed from High to Immediate
@Lukas Zapletal, I'd recommend leaving the old "invalid" string in app/models/setting.rb in place when cherry picking so we don't add new strings into a stable branch. Or perhaps better is change it to "is invalid %s" (no ":") so it matches one of our existing strings.
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
- Related to Tracker #3112: [TRACKER] Issues to be released in 1.3 RC or final added
- Related to deleted (Tracker #3112: [TRACKER] Issues to be released in 1.3 RC or final)
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by