Bug #2792: If you delete "PXE Localboot Default" cancel build fails - Foreman

Custom queries

3.10.0 release DONE
3.10.0 release TODO
3.11.0 release DONE
3.11.0 release TODO
3.8.1 release DONE
3.8.1 release TODO
3.9.2 release DONE
3.9.2 release TODO
All bugs by votes
All issues closed in the last 3 weeks
Easy and Trivial Issues
Easy Issues (only)
Foreman - new open issues in last 10 days
Good first issues - Foreman core
high prio open bugs
Host registration [open]
Mine
My issues closed in the last 3 weeks
old bugs
Open with target version set (aka blockers)
registration
taken-none
Team Atlas untriaged bugs
templates
Trivial Issues
Untriaged and opened in the past two weeks

Actions

Copy link

Bug #2792

open

If you delete "PXE Localboot Default" cancel build fails

Added by Florian Rosenegger almost 11 years ago. Updated over 10 years ago.

Status:

New

Priority:

Normal

Assignee:

Category:

Templates

Target version:

Difficulty:

Triaged:

Bugzilla link:

Pull request:

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

Hello,

i deleted the Provisioning template "PXE Localboot Default" and after that it was no longer possible to cancel a build for a host.

The error i got was:
Failed to save: Failed to generate PXELinux template: undefined method `template' for nil:NilClass

Via finish.sh script i also tried to call https://foreman/unattended/built but i only got a 409.

So maybe it would be good to make the Template undeleteable.

Thanks,
Florian

Related issues 4 (1 open — 3 closed)

Related to Foreman - Feature #3103: Read only provisioning/config templates for plugins	Closed	Stephen Benjamin	09/17/2013	Actions
Related to Foreman - Feature #7484: Per-subnet PXELinux global default files	New		09/17/2014	Actions
Has duplicate Foreman - Bug #2215: When PXE Localboot Default is deleted, causes nil error when cancelling build	Duplicate		02/17/2013	Actions
Has duplicate Foreman - Bug #4008: Disable 'build mode' unsuccessful	Duplicate		01/14/2014	Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Greg Sutcliffe almost 11 years ago

As we don't have an "undeleteable" feature for templates, I'm not sure this is a strong enough use case to implement one. It could be sensible to have some internal string which could be used if the template is not found, though. Any objections?

Actions

Copy link

Updated by Lukas Zapletal almost 11 years ago

Category set to Templates
Target version set to 1.3.0

Can't we just implement ON DELETE ERROR instead default ON DELETE NULL for this one?

Actions

Copy link

Updated by Greg Sutcliffe almost 11 years ago

We could, yes. I'm happy with either approach, tbh.

Actions

Copy link

Updated by Florian Rosenegger almost 11 years ago

Hello again,

i would also be happy if Foreman would just post a message that it is missing this special template (maybe with a hint to create one with the default name..)

My problem was that i just couldn't cancel the build but there was none whatsoever reason why (even in the log) and without Ohad and the IRC i wouldn't had a single idea what the error means.

The undeleteable feature for important templates was just one idea, but maybe/definitely not the best.

Actions

Copy link