Bug #223
closed
When a host update has errors then the render :edit loses required variables
Added by Paul Kelly about 14 years ago.
Updated almost 14 years ago.
Description
Scenario
The user is editing a pre-existing host. The user presses update. The record fails validation.
Instead of redirect_to @host we render :action => :edit
The Hostscontroller#edit method sets three variables which are used in the render :action => edit operation. These are not set when rendering from another method.
Files
All variables were replaced by their original fully qualified method path from the host object, in the supplied patch file
this patch doesn't remove the instance varibles which are set (e.g. @environment, @operatingsystem etc)
I tried sending the patch as an email, Maybe that as the problem. If I run git log -p
diff --git a/app/controllers/hosts_controller.rb b/app/controllers/hosts_controller.rb
index 6a20117..9630d7d 100644
--- a/app/controllers/hosts_controller.rb
+++ b/app/controllers/hosts_controller.rb
@@ -51,9 +51,6 @@ class HostsController < ApplicationController
def edit
@host = Host.find(params[:id])
- @environment = @host.environment
- @architecture = @host.architecture
- @operatingsystem = @host.operatingsystem
end
- Target version set to 0.1-5
what do you think of passing the parameters once redirecting to edit?, e.g.
def edit
@host = ..
@environment = params[:environment_id] || @host.environment
..
- Status changed from Ready For Testing to Assigned
- Assignee changed from Paul Kelly to Ohad Levy
- Status changed from Assigned to Ready For Testing
- % Done changed from 0 to 100
- Status changed from Ready For Testing to Closed
Also available in: Atom
PDF
Updated by 
Updated by