Project

General

Profile

Actions

Bug #19225

closed

Puppet version comparisons need to understand semantic versioning

Added by Dave Taylor about 7 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Puppet
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

The latest Puppet release is version 4.10.0. The version comparison in modules/puppet_proxy_puppet_api/plugin_configuration.rb uses a simple string less-than comparison against the string "4.4" to select which API endpoints to use, which therefore produces incorrect results for 4.10.0 - this needs modifying to use something more aware of semantic versioning (e.g. Gem::Version?).

There are a couple of other version comparisons that could probably do with being updated similarly, though they're less likely to cause problems - in modules/puppet_proxy/configuration_loader.rb and modules/puppet_proxy_legacy/plugin_configuration.rb

Actions

Also available in: Atom PDF