Actions
Bug #19225
closed
Puppet version comparisons need to understand semantic versioning
Description
The latest Puppet release is version 4.10.0. The version comparison in modules/puppet_proxy_puppet_api/plugin_configuration.rb uses a simple string less-than comparison against the string "4.4" to select which API endpoints to use, which therefore produces incorrect results for 4.10.0 - this needs modifying to use something more aware of semantic versioning (e.g. Gem::Version?).
There are a couple of other version comparisons that could probably do with being updated similarly, though they're less likely to cause problems - in modules/puppet_proxy/configuration_loader.rb and modules/puppet_proxy_legacy/plugin_configuration.rb
Updated by Anonymous about 7 years ago
- Project changed from Foreman to Smart Proxy
- Category changed from Puppet integration to Puppet
Updated by The Foreman Bot about 7 years ago
- Status changed from New to Ready For Testing
- Assignee set to Dominic Cleal
- Pull request https://github.com/theforeman/smart-proxy/pull/520 added
Updated by Dominic Cleal about 7 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 6c589cc86fd1f6e13f24a0c833eec040dc1fc9bf.
Updated by Dominic Cleal about 7 years ago
- translation missing: en.field_release set to 241
Actions