Project

General

Profile

Actions

Bug #15644

closed

import_facts assumes orchestration is available

Added by Daniel Lobato Garcia almost 8 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Category:
Orchestration
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Currently (core:develop, discovery:develop) provisioning a discovered host isn't possible. The `import_facts` method assumes there are two methods defined, enable_orchestration! and skip_orchestration! which do not exist for Host::Discovered.

This causes Foreman to throw the following error "undefined method `enable_orchestration!' for #<Host::Discovered:0x005623782265b8>". This is also true when importing facts for a host with :unattended => false

Host::Discovered doesn't need the Orchestration module for anything, however `import_facts` assumes it's there. This should involve two fixes:

1: in discovery, so that it can skip those calls (mocking them or something).
2: in core, so that import_facts doesn't have to rely on anything but Host::Base APIs. It should "know less", and let Host::Managed do these things (enable/skip orchestration) perhaps, as that's where it matters.

The code that causes this error will go in 1.12.1 https://github.com/theforeman/foreman/pull/3574/files#diff-07cbb99bfdb4bed86ad02486bb5adde2R174 so we should hurry up and release a version that fixes the problem. http://projects.theforeman.org/issues/15306


Related issues 2 (0 open2 closed)

Related to Foreman - Bug #15306: Orchestration does not roll back queued actions if DB error occursClosedShimon Shtein06/06/2016Actions
Related to Foreman - Bug #17118: Error pushing facts to foremanDuplicate10/27/2016Actions
Actions #1

Updated by Daniel Lobato Garcia almost 8 years ago

  • Related to Bug #15306: Orchestration does not roll back queued actions if DB error occurs added
Actions #2

Updated by Dominic Cleal almost 8 years ago

This is a bug in Foreman if Host::Base assumes a Host::Managed (Orchestration) method exists.

Actions #3

Updated by Daniel Lobato Garcia almost 8 years ago

  • Project changed from Discovery to Foreman
  • Category changed from Discovery plugin to Orchestration

Moving to Foreman then

Actions #4

Updated by Dominic Cleal almost 8 years ago

  • translation missing: en.field_release set to 161
Actions #6

Updated by The Foreman Bot almost 8 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Daniel Lobato Garcia
  • Pull request https://github.com/theforeman/foreman/pull/3637 added
Actions #7

Updated by Dominic Cleal almost 8 years ago

  • translation missing: en.field_release changed from 161 to 160
Actions #8

Updated by Daniel Lobato Garcia almost 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #9

Updated by Felix Barbeira over 7 years ago

  • Related to Bug #17118: Error pushing facts to foreman added
Actions #10

Updated by Daniel Lobato Garcia over 7 years ago

  • Target version set to 1.5.2
Actions

Also available in: Atom PDF