Project

General

Profile

Actions

Bug #1283

closed

Stray comma in highcharts code breaks IE

Added by Jacob McCann over 12 years ago. Updated over 12 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Our corporate standard browser is IE6 (ick). I've tested foreman in IE6 and IE7 and the charts do not work. I checked the highcharts site and it states that IE6 and IE7 are compatible browsers.

I found a stray comma that was breaking the js in IE.

For foreman 0.3 in file app/helpers/statistics_helper.rb:

      credits: {
      enabled: false,
      },

Is modified by removing the comma after 'false' (and I added some whitespace, but that isn't needed):

      credits: {
        enabled: false
      },

I was going to try and edit and patch this myself to submit, but then noticed foreman 0.4 changes this quite a bit. I'll keep looking to see if I can patch 0.4, but someone more familiar might be able to do this in 30 seconds. :P Or maybe its not even broke in 0.4?

Actions

Also available in: Atom PDF