Bug #4262: --organization-id is confusing as it requires the organization name and not its id - Katello - Foreman

Actions

Copy link

Bug #4262

closed

--organization-id is confusing as it requires the organization name and not its id

Added by Og Maciel over 10 years ago. Updated almost 6 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Category:

Hammer

Target version:

Katello 2.0

Difficulty:

Triaged:

Yes

Bugzilla link:

Pull request:

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

Playing with the gpg subcommand I noticed that organization-id, which is a required argument, doesn't take the organization ID value but the organization name, which is definitely bound to cause confusion. Can we change that to either use the ID (the best solution imho) or rename it to organization-name?

[root@qetello03 katello-deploy]# hammer organization list
------------------------------------------------------------------------
ID | NAME             | LABEL            | DESCRIPTION
------------------------------------------------------------------------
1  | ACME_Corporation | ACME_Corporation | ACME_Corporation Organization
------------------------------------------------------------------------
[root@qetello03 katello-deploy]# hammer gpg list --organization-id 1
404 Resource Not Found
[root@qetello03 katello-deploy]# hammer gpg list --organization-id ACME_Corporation
No data.

Actions

Copy link

Updated by Mike McCune over 10 years ago

+1 to just using the ID. We are working on a consistent name vs ID set of arguments to all the hammer commands but for now this should definitely use the ID like the argument states

Actions

Copy link