Bug #4181: V2: Api docs in foreman should not specify a root node for POST/PUT - Foreman

Custom queries

3.10.0 release DONE
3.10.0 release TODO
3.11.0 release DONE
3.11.0 release TODO
3.8.1 release DONE
3.8.1 release TODO
3.9.2 release DONE
3.9.2 release TODO
All bugs by votes
All issues closed in the last 3 weeks
Easy and Trivial Issues
Easy Issues (only)
Foreman - new open issues in last 10 days
Good first issues - Foreman core
high prio open bugs
Host registration [open]
Mine
My issues closed in the last 3 weeks
old bugs
Open with target version set (aka blockers)
registration
taken-none
Team Atlas untriaged bugs
templates
Trivial Issues
Untriaged and opened in the past two weeks

Actions

Copy link

Bug #4181

closed

V2: Api docs in foreman should not specify a root node for POST/PUT

Added by David Davis over 10 years ago. Updated almost 10 years ago.

Status:

Rejected

Priority:

Normal

Assignee:

Joseph Magen

Category:

API

Target version:

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/1601

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

See the screenshot. On the left is v2 spec and on the right is the actual apidoc from foreman v2 api.

Files

Screen Shot 2014-01-24 at 7.20.19 AM.png

View Screen Shot 2014-01-24 at 7.20.19 AM.png

66.5 KB

David Davis, 01/24/2014 02:26 PM

Related issues 3 (0 open — 3 closed)

Related to Foreman - Bug #4180: V2: The foreman V2 api doesn't support form data	Closed		01/24/2014	Actions
Related to Foreman - Bug #6248: Some JSON responses are still nested in a root node	Closed	Joseph Magen	06/17/2014	Actions
Related to Foreman - Bug #5178: Users API requires parameters to be wrapped	Closed	Joseph Magen	04/14/2014	Actions

Issue # Delay: days Cancel

History
Notes
Property changes

Actions

Copy link

Updated by Dominic Cleal over 10 years ago

Category set to API

Actions

Copy link

Updated by Adam Price about 10 years ago

Priority changed from Normal to High

Actions

Copy link

Updated by Joseph Magen almost 10 years ago

David,

The rails default is to return a blank response for PUT and DELETE. Foreman modified the method `api_behavior` in ActionController::Responder to also return object on PUT and DELETE using the rails code

display resource

See app/controllers/api/api_responder.rb

This code is currently used by all POST, PUT, and DELETE requests.

Note that ONLY GET requests use the RABL templates. Return response of POST, PUT, and DELETE did NOT use RABL.

Since this is just for documentation reasons, I suggest to use the Rails standard as is and to change the documentation accordingly.

In short, PUT/POST/DELETE can receive json with OR without a root, but the response will with WITH root node. However, on the GET, the response is WITHOUT rootnode since we configured the RABL templates to do so.

Actions

Copy link

Updated by David Davis almost 10 years ago

Priority changed from High to Low

Joseph,

First of all, this has nothing to do with what's being returned. This has do with the data that's being sent to create/update. So I'm not sure I understand the first part of your comment.

Regarding the second part of your comment, the problem is that the api doc (and thus apipie/hammer requests) is not consistent as in certain parts of the fortello API such as organization, there's no root node whereas other parts of the api such as domain, there is. I think that'll confuse users and create problems for us developers.

This is only documentation so I don't think it's a high priority. However, the apipie (and thus hammer requests, etc) use this documentation so it affects the formats of the requests that are being sent to/from katello and foreman. It's caused issues in the past like http://projects.theforeman.org/issues/4180 was difficult to solve as only half the requests (the un-nested ones) were failing.

I still think we need this but it's not a high priority.

Actions

Copy link

Updated by David Davis almost 10 years ago

Related to Bug #4180: V2: The foreman V2 api doesn't support form data added

Actions

Copy link

Updated by David Davis almost 10 years ago

Priority changed from Low to Normal

Actions

Copy link

Updated by Joseph Magen almost 10 years ago

Status changed from New to Ready For Testing
Assignee set to Joseph Magen
Target version set to 1.8.1

https://github.com/theforeman/foreman/pull/1518

Actions

Copy link

Updated by Dominic Cleal almost 10 years ago

Subject changed from V2: Api docs in foreman should not require a root node for POST/PUT to V2: Api docs in foreman should not specify a root node for POST/PUT
Status changed from Ready For Testing to New
Assignee deleted (~~Joseph Magen~~)
Target version deleted (~~1.8.1~~)

Resetting this, because the pull request mentioned changes the response from the API and doesn't change the documentation, as David said. The apipie description of the APIv2 actions includes a wrapped node, which in Foreman's API is optional and as per the documentation (in the screenshot provided) is not used.

Actions

Copy link