Project

General

Profile

Actions

Bug #25230

closed

compute resource test connection is html incorrectly escaped

Added by Ohad Levy over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

see attachment

steps to reproduce

1. create / edit a compute resource
2. click on test connection
3. see incorrect toast message.


Files

cr-test.png View cr-test.png 5.9 KB Ohad Levy, 10/18/2018 12:42 PM

Related issues 2 (0 open2 closed)

Related to Foreman - Bug #24807: CVE-2018-16861 - toast notification sends strings through as HTMLClosedAvi SharvitActions
Has duplicate Foreman - Bug #25456: Test connection on compute resource shows notification with html tagsDuplicateActions
Actions #1

Updated by Ohad Levy over 5 years ago

  • Related to Bug #24807: CVE-2018-16861 - toast notification sends strings through as HTML added
Actions #2

Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Tomer Brisker
  • Pull request https://github.com/theforeman/foreman/pull/6154 added
Actions #3

Updated by Tomer Brisker over 5 years ago

  • Category changed from Compute resources to Web Interface
  • Triaged changed from No to Yes

The same issue is also present for email and auth source test connection buttons.

Actions #4

Updated by Ohad Levy over 5 years ago

  • Target version set to 1.20.0

I would suggest cherrypicking to 1.20?

Actions #5

Updated by Tomer Brisker over 5 years ago

  • Status changed from Ready For Testing to Closed
Actions #6

Updated by Tomer Brisker over 5 years ago

  • Fixed in Releases 1.20.0 added

cherry-picked.

Actions #7

Updated by Tomer Brisker over 5 years ago

  • Has duplicate Bug #25456: Test connection on compute resource shows notification with html tags added
Actions

Also available in: Atom PDF