Feature #2414: Remove Puppet from Foreman core - Foreman

Custom queries

3.10.0 release DONE
3.10.0 release TODO
3.11.0 release DONE
3.11.0 release TODO
3.8.1 release DONE
3.8.1 release TODO
3.9.2 release DONE
3.9.2 release TODO
All bugs by votes
All issues closed in the last 3 weeks
Easy and Trivial Issues
Easy Issues (only)
Foreman - new open issues in last 10 days
Good first issues - Foreman core
high prio open bugs
Host registration [open]
Mine
My issues closed in the last 3 weeks
old bugs
Open with target version set (aka blockers)
registration
taken-none
Team Atlas untriaged bugs
templates
Trivial Issues
Untriaged and opened in the past two weeks

Actions

Copy link

Feature #2414

closed

Remove Puppet from Foreman core

Added by Dominic Cleal about 11 years ago. Updated over 10 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Greg Sutcliffe

Category:

Puppet integration

Target version:

1.3.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

We need to complete removing the Puppet dependency from Foreman core, so all Puppet usage is in the smart proxy only. This will make it optional for people who don't use Puppet, plus avoid conflicts we've seen when loading Puppet as a library into the full Rails application (monkey patching).

Some tasks:

1. Reports need to be parsed in the report handler, then uploaded as JSON etc. (app/models/report.rb)
2. Fact uploads need to be hashes only, no Puppet::Node::Facts (app/models/host/managed.rb)
3. PuppetSetting checks the PUPPETVERSION constant (lib/puppet_setting.rb)

Related issues 6 (1 open — 5 closed)

Related to Foreman - Bug #2413: NoMethodError on Puppet 3.2 and Ruby 1.9.2	Closed		04/19/2013	Actions
Related to Foreman - Support #2435: Unable to authentication with LDAP server using ldaps	Closed			Actions
Related to Foreman - Bug #2448: "vm is required for this operation" when viewing oVirt VMs with Puppet 3.2	Resolved	Dominic Cleal	05/01/2013	Actions
Related to Foreman - Bug #2461: Cannot create a host without a puppet proxy	Closed	Greg Sutcliffe	05/06/2013	Actions
Related to Foreman - Bug #3030: Facter isn't loaded, but is referenced in DB migrations etc.	Closed	Greg Sutcliffe	09/05/2013	Actions
Related to Foreman - Bug #3236: prod2dev assumes all production tables exist in development	New		10/10/2013	Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Dominic Cleal about 11 years ago

Assignee deleted (~~Ohad Levy~~)

Related is that we use Facter too in lib/foreman/default_settings/loader.rb and lib/tasks/reset_permissions.rake to get the current domain and Puppet version again, plus in DB migrations.

Actions

Copy link

Updated by Greg Sutcliffe about 11 years ago

I can take it out of the settings in my plugin-settings PR if needed - it's only used to get the domain, I can add a fallback to shell out to `dnsdomainname` if Facter can't be loaded. Same can probably be done in the permissions.

Actions

Copy link

Updated by Dominic Cleal about 11 years ago

Greg Sutcliffe wrote:

I can take it out of the settings in my plugin-settings PR if needed - it's only used to get the domain, I can add a fallback to shell out to `dnsdomainname` if Facter can't be loaded. Same can probably be done in the permissions.

I wouldn't worry for now, since we have the same use case in the settings loader. When we solve it there we can update both. Facter's less of a problem anyway, maybe it's even a reasonable dependency.

Actions

Copy link