Project

General

Profile

Actions
Copy link

Bug #17502

closed

Foreman discovery proxy feature installation via puppet not working unless class is specified

Added by N V over 7 years ago. Updated over 7 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
Foreman modules
Target version:
-
Difficulty:
Triaged:
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Hello,

The installation of the Foreman Discovery Proxy via Puppet does not work unless the class foreman_proxy::plugin::discovery is included explicitly. This is how my hiera config file for the host looks:

---
classes: [foreman_proxy, 'foreman_proxy::plugin::discovery']

foreman_proxy::dhcp: true
foreman_proxy::tftp: true
foreman_proxy::plugin::discovery::install_images: true
foreman_proxy::plugin::discovery: true

foreman_proxy::dhcp_managed: false
foreman_proxy::tftp_managed: true
foreman_proxy::puppet: false
foreman_proxy::puppetca: false

By "does not work" I mean the puppetrun will work, but won't actually setup the necessary to make discovery work (no fdi image download, no ruby-foreman-discovery package installation, no smart proxy config).

Foreman 1.13.2, Ubuntu 16.04.

Actions
Copy link
 #1

Updated by Lukas Zapletal over 7 years ago

  • Project changed from Discovery to Installer
  • Category changed from Discovery plugin to Foreman modules

Thanks for report, this is for installer component.

Actions
Copy link
 #2

Updated by Dominic Cleal over 7 years ago

  • Status changed from New to Need more information
  • translation missing: en.field_release deleted (207)

I'm not sure I understand the bug report here, the class has to be included to be used. What did you expect?

Actions
Copy link
 #3

Updated by N V over 7 years ago

Dominic Cleal wrote:

I'm not sure I understand the bug report here, the class has to be included to be used. What did you expect?

Definitely true. But I was told in IRC that the install_images class included discovery:

install_images should include that class, see line 26-28 here (https://github.com/theforeman/puppet-foreman_proxy/blob/af05b0791d347451f301a5995e4b150b738966b4/manifests/plugin/discovery.pp#L28

I could well be doing something wrong.

Actions
Copy link
 #4

Updated by Dominic Cleal over 7 years ago

There isn't an install_images class, the class is "foreman_proxy::plugin::discovery". That has to be included by you.

The line you highlighted isn't including a class, it's installing the package inside the foreman_proxy::plugin::discovery class. If you include that class then it should install.

Actions
Copy link
 #5

Updated by N V over 7 years ago

Dominic Cleal wrote:

There isn't an install_images class, the class is "foreman_proxy::plugin::discovery". That has to be included by you.

The line you highlighted isn't including a class, it's installing the package inside the foreman_proxy::plugin::discovery class. If you include that class then it should install.

I guess this can be closed as "non valid" then. Thanks for your clarifications, Dominic.

Actions
Copy link
 #6

Updated by Dominic Cleal over 7 years ago

  • Status changed from Need more information to Rejected
Actions
Copy link

Also available in: Atom PDF