Templates attached,
As I wrote before i got another template when i refer to it with hostname and another when with token.
I have attached both.

Dominic Cleal wrote:

Thanks, that's a little clearer. The "lang" line near the top is also different - in the previewed file it's pl_PL and in the token-fetched file it's en_US.UTF-8, suggesting @host.params is returning different results. I think this points to the parameters not working generally, not only in ptable templates.

Yes but only did not work when i use some forman_params in ptable, then whole template was not propertly rendered.

Where are lang and the root_size parameters set? On the host itself or something like a domain, OS or globally?

I try to set them on group, and on host.

If you could make the token request while running tail -f /var/log/foreman/production.log and attach the log, that may be helpful. It would be great if you could enable debugging first with "permissions" and "sql" logs enabled by following https://theforeman.org/manuals/1.13/index.html#7.2Debugging.

Thanks for providing this info.

Logs attached.

I'm affected by this too. For me it happens on any template (ptable or kickstart). I created a test Kickstart template with the following contents:

<%#
kind: provision
name: Host Params Bug Test
-%>
<%= @host.params %>

Here are the results from the different URLs. Notice that ?token is missing all params shown in the other URLs except for remote execution stuff for some reason:

http://foreman01.corp.bardel.ca/unattended/provision?token=620640d5-a57d-4b61-84b4-2309213cb846

{"remote_execution_ssh_keys"=>["ssh-rsa <HIDDEN> puppet-foreman01"], "remote_execution_ssh_user"=>"root", "remote_execution_effective_user_method"=>"sudo"}

http://foreman01.corp.bardel.ca/unattended/provision?spoof=10.49.78.64

{"bootloader-append"=>"nofb splash=quiet crashkernel=auto nomodeset quiet net.ifnames=0", "domain-shortname"=>"BARDEL", "enable-puppetlabs-repo"=>"true", "force-puppet"=>"true", "join-domain-password"=>"<HIDDEN>", "join-domain-user"=>"<HIDDEN>", "md2-mount-point"=>"", "ntp-server"=>"ntp.corp.bardel.ca", "os-drive-type"=>"single", "time-zone"=>"America/Vancouver", "x-server"=>"false", "remote_execution_ssh_keys"=>["ssh-rsa <HIDDEN> puppet-foreman01"], "remote_execution_ssh_user"=>"root", "remote_execution_effective_user_method"=>"sudo"}

http://foreman01.corp.bardel.ca/unattended/provision?hostname=kc-centos7-01.corp.bardel.ca

{"bootloader-append"=>"nofb splash=quiet crashkernel=auto nomodeset quiet net.ifnames=0", "domain-shortname"=>"BARDEL", "enable-puppetlabs-repo"=>"true", "force-puppet"=>"true", "join-domain-password"=>"<HIDDEN>", "join-domain-user"=>"<HIDDEN>", "md2-mount-point"=>"", "ntp-server"=>"ntp.corp.bardel.ca", "os-drive-type"=>"single", "time-zone"=>"America/Vancouver", "x-server"=>"false", "remote_execution_ssh_keys"=>["ssh-rsa <HIDDEN> puppet-foreman01"], "remote_execution_ssh_user"=>"root", "remote_execution_effective_user_method"=>"sudo"}

I've also attached my production.log with sql and permission logging.

Thanks.

• LDAP is configured on the foreman server that has been upgraded.
• The migration itself from 1.12.4 to 1.13.2

I've added the production.log set for debugging with sql and permissions enabled.

Below the installed plugins:

Foreman plugin: foreman-tasks, 0.8.2, Ivan Nečas, The goal of this plugin is to unify the way of showing task statuses across the Foreman instance.
It defines Task model for keeping the information about the tasks and Lock for assigning the tasks
to resources. The locking allows dealing with preventing multiple colliding tasks to be run on the
same resource. It also optionally provides Dynflow infrastructure for using it for managing the tasks.
Foreman plugin: foreman_bootdisk, 8.0.2, Dominic Cleal, Plugin for Foreman that creates iPXE-based boot disks to provision hosts without the need for PXE infrastructure.
Foreman plugin: foreman_discovery, 7.0.0, Amos Benari,Bryan Kearney,ChairmanTubeAmp,Daniel Lobato García,Dominic Cleal,Eric D. Helms,Frank Wall,Greg Sutcliffe,Imri Zvik,Joseph Mitchell Magen,Lukas Zapletal,Lukáš Zapletal,Marek Hulan,Martin Bačovský,Matt Jarvis,Michael Moll,Nick,Ohad Levy,Ori Rabin,Petr Chalupa,Phirince Philip,Scubafloyd,Shlomi Zadok,Stephen Benjamin,Yann Cézard, MaaS Discovery Plugin engine for Foreman
Foreman plugin: foreman_hooks, 0.3.12, Dominic Cleal, Plugin engine for Foreman that enables running custom hook scripts on Foreman events
Foreman plugin: foreman_salt, 7.0.2, Stephen Benjamin, Foreman Plug-in for Salt
Foreman plugin: foreman_setup, 5.0.0, Dominic Cleal, Plugin for Foreman that helps set up provisioning.
Foreman plugin: foreman_templates, 3.1.0, Greg Sutcliffe, Engine to synchronise provisioning templates from GitHub

Thanks, I can reproduce it now - no plugins necessary.

This looks like it only affects the Redhat and Solaris OS families, as Foreman::Renderer calls @host.diskLayout in the jumpstart/kickstart_attributes methods prior to the main template being rendered from UnattendedController. Calling diskLayout causes the renderer to be used and for .params to be cached on the host model.

There is no user set while diskLayout is called, it's only set (from the fix in #15599) during the main template render in UnattendedController.

The user must also be set during load_template_vars in the UnattendedController.

Applied in changeset f8a2b268619722b7b696ab5ab000d2b0e5ae42df.