Refactor #14434
closed
Refactor host token support into concern
Added by Dominic Cleal about 8 years ago.
Updated almost 6 years ago.
Description
The rails-observers gem can be removed with a small amount of refactoring. It was added with Rails 4 support in #7230 as it was removed from Rails core.
It's used for the HostObserver which contains one after_validation method to expire or generate build tokens when the build state changes, but this could be refactored away from observers.
Dropping the dependency will provide a very marginal installation and speed improvement.
- Subject changed from Remove rails-observers dependency to Refactor host token support into concern
It isn't possible to remove the dependency entirely as the audited gem still depends on it, I missed that. It's possible to remove the usage from Foreman core though and refactor the token support into a single concern.
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/3383 added
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
- translation missing: en.field_release set to 136
Also available in: Atom
PDF
Updated by 
Updated by