Bug #11862: Smart variables with illegal characters raises an exception - Foreman

Custom queries

3.10.0 release DONE
3.10.0 release TODO
3.11.0 release DONE
3.11.0 release TODO
3.8.1 release DONE
3.8.1 release TODO
3.9.2 release DONE
3.9.2 release TODO
All bugs by votes
All issues closed in the last 3 weeks
Easy and Trivial Issues
Easy Issues (only)
Foreman - new open issues in last 10 days
Good first issues - Foreman core
high prio open bugs
Host registration [open]
Mine
My issues closed in the last 3 weeks
old bugs
Open with target version set (aka blockers)
registration
taken-none
Team Atlas untriaged bugs
templates
Trivial Issues
Untriaged and opened in the past two weeks

Actions

Copy link

Bug #11862

closed

Smart variables with illegal characters raises an exception

Added by Ori Rabin over 8 years ago. Updated almost 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Tom Caspy

Category:

Parameters

Target version:

1.10.1

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/2748

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

For example using rocket hash instead of json:
1) create a smart variable of type hash
2) change default value to: {'a'=>'b'}
3) try to save
there should be a validation message that this is not a valid json/yaml but an exception is received:
(<unknown>): did not find expected ',' or '}' while parsing a flow mapping at line 1 column 1

Related issues 1 (0 open — 1 closed)

Related to Foreman - Refactor #10232: move validations and casting out of lookup keys and values into single-responsibility classes

Closed

Tom Caspy

04/22/2015

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Dominic Cleal over 8 years ago

I can't reproduce this to determine if it's a regression. All of my attempts simply fail validation on the default value field. Could you confirm when it was introduced please, and some more details about how to reproduce? (e.g. which UI or API, logs, stack trace)

Actions

Copy link

Updated by Tom Caspy over 8 years ago

Reproduction steps:

edit puppetclass
click on smart variable
add a new smart variable of type "hash"
input a hash which isn't a valid json or yaml (i.e. '{"foo" => "bar"}' or something similar)
submit and see exception

Expected result - show a validation message saying this isn't a valid hash.
Expected UX - have a key-value editor which turns into a valid json on submit and save the user the trouble (out of scope of this ticket but idea worth mentioning)

Actions

Copy link