Bug #10546: Reduce the number of interfaces duplicates - Foreman

Custom queries

3.10.0 release DONE
3.10.0 release TODO
3.11.0 release DONE
3.11.0 release TODO
3.8.1 release DONE
3.8.1 release TODO
3.9.2 release DONE
3.9.2 release TODO
All bugs by votes
All issues closed in the last 3 weeks
Easy and Trivial Issues
Easy Issues (only)
Foreman - new open issues in last 10 days
Good first issues - Foreman core
high prio open bugs
Host registration [open]
Mine
My issues closed in the last 3 weeks
old bugs
Open with target version set (aka blockers)
registration
taken-none
Team Atlas untriaged bugs
templates
Trivial Issues
Untriaged and opened in the past two weeks

Actions

Copy link

Bug #10546

closed

Reduce the number of interfaces duplicates

Added by Julien Pivotto almost 9 years ago. Updated almost 9 years ago.

Status:

Duplicate

Priority:

Normal

Assignee:

Category:

Network

Target version:

Difficulty:

easy

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/2392

Fixed in Releases:

Found in Releases:

1.8.0

Red Hat JIRA:

Description

When the mac address of an interface changes, it gets duplicate. Example with a bonding interface which has mac address ff:ff:ff:ff:ff:ff when down. We should handle that in a better way and avoid as much duplicates as possible.

Related issues 3 (0 open — 3 closed)

Related to Foreman - Bug #10805: VLAN interface attached to bond is wrongly created as Bond	Closed	Marek Hulán	06/13/2015	Actions
Related to Foreman - Bug #10888: duplicate interfaces when using bond device	Closed	Marek Hulán	06/20/2015	Actions
Related to Foreman - Bug #10607: bonding on ubuntu causes foreman to create an interface after each ubuntu server reboot	Closed	Marek Hulán	05/26/2015	Actions

Issue # Delay: days Cancel

History
Notes
Property changes

Actions

Copy link

Updated by The Foreman Bot almost 9 years ago

Status changed from New to Ready For Testing
Pull request https://github.com/theforeman/foreman/pull/2392 added
Pull request deleted ()

Actions

Copy link

Updated by Julien Pivotto almost 9 years ago

https://github.com/theforeman/foreman/pull/2392/files

Actions

Copy link

Updated by Julien Pivotto almost 9 years ago

Category set to Network
Difficulty set to easy

Actions

Copy link

Updated by Marek Hulán almost 9 years ago

This was on purpose because we can't really say whether interface got different mac or there's new one with the same mac. Note that vlans, aliases and bonds has the same mac of physical interface they're attached to. Seems like bonds would need special treatment, other virtual interfaces that are down were not part of facts upload. Could you please upload example of facter output with bond that's down? I think the PR does not solve the issue properly. I'm afraid we don't even import bond interfaces as bonds but generic managed interface.

Actions

Copy link

Updated by Julien Pivotto almost 9 years ago

Bond interfaces are imported as bond -- they are recognized by their name in the FactParser. When the bond is down the facter output is the same -- just that the bond mac address is blank.

"This was on purpose because we can't really say whether interface got different mac or there's new one with the same mac. "

My proposal is just to pick the interface with the same mac address and name, if not the interface with the mac address if the mac address is not blank, and then only pick the name.

In Linux the unique identifier for an interface is the name. The mac address can be shared, like you said.

Actions

Copy link