Project

General

Profile

Actions

Bug #9359

closed

puppet_ca parameter made available for unmanaged hosts

Added by Chris Pisano about 9 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Category:
External Nodes
Target version:
Difficulty:
easy
Triaged:
Fixed in Releases:
Found in Releases:

Description

Right now in order for the puppet_ca parameter to be made available unattended needs to be set to true and a host needs to be managed. Is it possible to change the check to allow the puppet_ca parameter to be made available for unmanaged hosts as well?


Related issues 1 (0 open1 closed)

Has duplicate Foreman - Feature #13060: Missing puppetca in YAML parametersDuplicate01/08/2016Actions
Actions #1

Updated by Dominic Cleal about 9 years ago

  • Category set to External Nodes
  • Difficulty set to easy
Actions #2

Updated by Chris Pisano almost 9 years ago

After reaching out in #theforeman-dev it seems like line 357 in

https://github.com/theforeman/foreman/blob/develop/app/models/host/managed.rb#L357

would need to be moved outside of the if block and placed where param["puppetmaster"] is. According to lines 53 - 62 in

https://github.com/theforeman/foreman/blob/develop/app/helpers/hosts_and_hostgroups_helper.rb#L53-L62

puppet_ca is only enabled if there is a proxy with the CA feature enabled. It seems like we wouldn't want puppet_ca to be displayed if it wasn't enabled. I'm not sure what to do with line 357 in managed.rb since :unattended doesn't seem to have a relation to the ca proxy feature.

Actions #3

Updated by Dominic Cleal over 8 years ago

  • Has duplicate Feature #13060: Missing puppetca in YAML parameters added
Actions #4

Updated by Chris Pisano over 8 years ago

  • Assignee set to Chris Pisano
Actions #5

Updated by The Foreman Bot over 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3039 added
Actions #6

Updated by Dominic Cleal over 8 years ago

  • Assignee changed from Chris Pisano to julien ippolito
  • translation missing: en.field_release set to 104
Actions #7

Updated by Anonymous over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF