Project

General

Profile

Actions
Copy link

Bug #9231

closed

Exception message missing when ENC fails to render

Added by Dominic Cleal about 9 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
David Davis
Category:
External Nodes
Target version:
1.7.3
Difficulty:
easy
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/2131
Fixed in Releases:
Found in Releases:
1.7.2
Red Hat JIRA:

Description

From http://projects.theforeman.org/issues/9185#note-3, when the ENC fails to render, the exception message isn't logged:

Failed to generate external nodes for host4.cloud.example.com with

It appears that refactoring in 4f7a4d0ba84f43e3cb0d422d9f5e82b01588f21b changed the logging message to use $ERROR_INFO instead of $!. This variable is only available if the 'English' library is loaded, which it doesn't appear to be.

Related issues 3 (0 open — 3 closed)

Related to Foreman - Bug #9185: Deleting a network interface breaks all puppet agent syncingResolved02/01/2015Actions
Related to Foreman - Feature #3809: Add rubocop to foremanClosedDavid DavisActions
Has duplicate Foreman - Bug #9305: ENC failures are not logged correctlyDuplicate02/10/2015Actions
Actions
Copy link
 #1

Updated by Dominic Cleal about 9 years ago

  • Related to Bug #9185: Deleting a network interface breaks all puppet agent syncing added
Actions
Copy link
 #2

Updated by Dominic Cleal about 9 years ago

Actions
Copy link
 #3

Updated by Dominic Cleal about 9 years ago

  • Difficulty set to easy
Actions
Copy link
 #4

Updated by Dominic Cleal about 9 years ago

There's another instance in app/models/host/managed.rb, so these either need reverting (and disable Style/SpecialGlobalVars in rubocop again) or require English from something core in config/.

Actions
Copy link
 #5

Updated by David Davis about 9 years ago

  • Assignee set to David Davis
Actions
Copy link
 #6

Updated by The Foreman Bot about 9 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2131 added
  • Pull request deleted ()
Actions
Copy link
 #7

Updated by Ohad Levy about 9 years ago

  • Has duplicate Bug #9305: ENC failures are not logged correctly added
Actions
Copy link
 #8

Updated by David Davis about 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #9

Updated by Dominic Cleal about 9 years ago

  • translation missing: en.field_release set to 32
Actions
Copy link

Also available in: Atom PDF