Project

General

Profile

Actions

Bug #8874

closed

gettext 3.1.13+ causes locale tx-update errors due to .edit.po files

Added by Dominic Cleal about 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Internationalization
Target version:
Fixed in Releases:
Found in Releases:

Description

Since gettext 3.1.13+ locale updates aren't working quite right, as some new .edit.po and timestamp files in the locale directories are created, which breaks the git commits in our Makefile.

The intention appears to be that we pull translations into the .edit.po files instead, which get merged into the .po files by gettext.


Related issues 2 (0 open2 closed)

Related to Hammer CLI - Tracker #8978: Drop Ruby 1.8 support in hammerClosed01/15/2015

Actions
Blocks Foreman - Bug #13033: plugin:gettext rake task doesn't load with gettext_i18n_rails_js 1.xClosedStephen Benjamin01/07/2016Actions
Actions #1

Updated by Dominic Cleal about 9 years ago

Previously...

  • make -C locale tx-update
    • pulls rails locale files
    • runs tx pull, which overwrites locale/*/foreman.po
    • git commits
    • runs rake locale:po_to_json, which converts foreman.po to app.js
    • runs rake locale:find, which overwrites locale/foreman.po, re-merges locale/*/foreman.po
    • reverts locale/*/foreman.po from previous step
    • git amends

Now there's an .edit.po and real .po file, tx pull should in theory go to the edit file first, then let gettext handle merging back to .po.

Actions #2

Updated by Dominic Cleal about 9 years ago

I opened https://github.com/ruby-gettext/gettext/issues/36 to ask for examples or help on what the .edit.po is for, and how it should be used before deciding exactly how to proceed.

Actions #3

Updated by Anonymous about 9 years ago

  • Related to Tracker #8978: Drop Ruby 1.8 support in hammer added
Actions #4

Updated by The Foreman Bot about 9 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2096 added
  • Pull request deleted ()
Actions #5

Updated by Dominic Cleal about 9 years ago

Now:

  • make -C locale tx-update
    • pulls rails locale files
    • runs rake locale:find, which updates foreman.pot, generates .po and .edit.po files
    • runs tx pull, which overwrites locale/*/foreman.edit.po
    • runs rake locale:find, which merges into locale/*/foreman.po
    • runs rake locale:po_to_json, which converts foreman.po to app.js
    • git commits
Actions #6

Updated by Dominic Cleal about 9 years ago

  • translation missing: en.field_release set to 28

Needed to rebuild POT/PO files in 1.8.

Actions #7

Updated by Dominic Cleal almost 9 years ago

  • translation missing: en.field_release changed from 28 to 50
Actions #8

Updated by Dominic Cleal almost 9 years ago

  • translation missing: en.field_release changed from 50 to 56
Actions #9

Updated by Dominic Cleal almost 9 years ago

  • translation missing: en.field_release deleted (56)
Actions #10

Updated by Dominic Cleal about 8 years ago

  • Blocks Bug #13033: plugin:gettext rake task doesn't load with gettext_i18n_rails_js 1.x added
Actions #11

Updated by The Foreman Bot about 8 years ago

  • Pull request https://github.com/theforeman/foreman_discovery/pull/244 added
Actions #12

Updated by Dominic Cleal about 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #13

Updated by Dominic Cleal about 8 years ago

  • translation missing: en.field_release set to 71
Actions

Also available in: Atom PDF