Bug #8739

default root_pass not used if password field is an empty string

Added by Konrad Lother over 3 years ago. Updated almost 3 years ago.

Status:Closed
Priority:Normal
Assigned To:Dominic Cleal
Category:Host creation
Target version:-
Difficulty: Bugzilla link:1255021
Found in release:1.7.0 Pull request:https://github.com/theforeman/foreman/pull/2024
Story points-
Velocity based estimate-
Release1.7.3Release relationshipAuto

Description

Provisioning a new host is not using the root_pass set in Administer -> Settings if an empty string is set as password either on the host itself or in a hostgroup.

The default password should be used even if the root password is an empty string as you can not reset it to NULL in the web-ui.


Related issues

Related to Foreman - Bug #8807: root password handling is broken New 12/29/2014

Associated revisions

Revision db176297
Added by Dominic Cleal over 3 years ago

fixes #8739 - use global setting when hostgroup root_pass is blank

A blank (not nil) root_pass on hostgroups was preventing correct inheritance
from settings in both hosts and nested hostgroups.

root_pass was also being copied from parents/settings to hostgroups when they
were saved, when it should remain blank to continue inheriting. Only hosts
are meant to copy the password on save.

Revision 0a64a09b
Added by Dominic Cleal about 3 years ago

fixes #8739 - use global setting when hostgroup root_pass is blank

A blank (not nil) root_pass on hostgroups was preventing correct inheritance
from settings in both hosts and nested hostgroups.

root_pass was also being copied from parents/settings to hostgroups when they
were saved, when it should remain blank to continue inheriting. Only hosts
are meant to copy the password on save.

(cherry picked from commit db17629709a649bd49b83d60422b905c9db965be)

History

#1 Updated by Dominic Cleal over 3 years ago

  • Status changed from New to Assigned
  • Assigned To set to Dominic Cleal

#2 Updated by The Foreman Bot over 3 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2024 added

#3 Updated by Dominic Cleal over 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal over 3 years ago

  • Related to Bug #8807: root password handling is broken added

#5 Updated by Dominic Cleal over 3 years ago

  • Release set to 1.8.0

#6 Updated by Dominic Cleal over 3 years ago

  • Release changed from 1.8.0 to 1.7.3

#7 Updated by Bryan Kearney almost 3 years ago

  • Bugzilla link set to 1255021

Also available in: Atom PDF