Project

General

Profile

Actions

Refactor #8721

closed

Replace all uses of jQuery(item).attr('id') with item.id

Added by Tomer Brisker over 9 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Performance
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

No need to use jQuery when we don't have to.
Using plain item.id is about 100X faster:
http://jsperf.com/jquery-item-attr-id-vs-item-id

Actions #1

Updated by The Foreman Bot over 9 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2020 added
  • Pull request deleted ()
Actions #2

Updated by Anonymous over 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #3

Updated by Dominic Cleal over 9 years ago

  • translation missing: en.field_release set to 28
Actions

Also available in: Atom PDF