Project

General

Profile

Actions
Copy link

Bug #7314

closed

Tests shouldn't stub settings

Added by Stephen Benjamin over 9 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Stephen Benjamin
Category:
Tests
Target version:
1.7.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/1722
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

If you stub Settings[], and a plug-in later comes along and chains the method and references a Setting that's not stubbed, it will cause the test to fail.

Setting the setting value in the test works, so there's really no need to stub Settings, is there?

Actions
Copy link
 #1

Updated by The Foreman Bot over 9 years ago

  • Status changed from New to Ready For Testing
  • Target version set to 1.7.4
  • Pull request https://github.com/theforeman/foreman/pull/1722 added
  • Pull request deleted ()
Actions
Copy link
 #2

Updated by Anonymous over 9 years ago

  • Target version changed from 1.7.4 to 1.7.3
Actions
Copy link
 #3

Updated by Dominic Cleal over 9 years ago

  • Assignee set to Stephen Benjamin
  • translation missing: en.field_release set to 21
Actions
Copy link
 #4

Updated by Anonymous over 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link

Also available in: Atom PDF