Project

General

Profile

Actions

Bug #6825

closed

refactor api/v2/filters_controller.rb to use find_optional_nested_object and add Authorizable to class Role

Added by Joseph Magen over 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
API
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

after refactoring filters_controller to use find_optional_nested_object, it was discovered that Role doesn't respond to #authorized method, so include Authorizable needs to be added to role.rb

This is commit was need for tests to pass in PR #4181


Related issues 1 (0 open1 closed)

Related to Foreman - Bug #14182: Roles index does not use authorize scopeClosedMarek Hulán03/14/2016Actions
Actions #1

Updated by The Foreman Bot over 9 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/1630 added
  • Pull request deleted ()
Actions #2

Updated by Anonymous over 9 years ago

  • Target version changed from 1.8.0 to 1.7.5
Actions #3

Updated by Dominic Cleal over 9 years ago

  • translation missing: en.field_release set to 10
Actions #4

Updated by Joseph Magen over 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #5

Updated by Yama Kasi over 9 years ago

This fix doesn't work on 1.5.2 ?

It seems to remain.

Actions #6

Updated by Dominic Cleal over 9 years ago

Yama Kasi wrote:

This fix doesn't work on 1.5.2 ?

It seems to remain.

Huh? I think you have the wrong ticket.

Actions #7

Updated by Yama Kasi over 9 years ago

Dominic Cleal wrote:

Yama Kasi wrote:

This fix doesn't work on 1.5.2 ?

It seems to remain.

Huh? I think you have the wrong ticket.

Nudik pointed me to this and indeed it happens on 1.5.2 (too)!

Actions #8

Updated by Marek Hulán about 8 years ago

  • Related to Bug #14182: Roles index does not use authorize scope added
Actions

Also available in: Atom PDF