Bug #5696: Migration of Admin users from 1.4 -> 1.5 results in "Role Name_username" roles that cannot be removed and cleaned up. - Foreman

Actions

Copy link

Bug #5696

closed

Migration of Admin users from 1.4 -> 1.5 results in "Role Name_username" roles that cannot be removed and cleaned up.

Added by Derek Wright almost 10 years ago. Updated almost 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Marek Hulán

Category:

Users, Roles and Permissions

Target version:

1.5.1

Difficulty:

Triaged:

Bugzilla link:

1105570

Pull request:

Fixed in Releases:

Found in Releases:

1.5.0

Red Hat JIRA:

Description

Initially produced by exporting prod Foreman 1.4.2 DB into vagrant instance for upgrade testing. After upgrading vagrant instance to 1.5, users marked as Admin had migration roles created but no "Roles" tab under their username to clean up the old roles. Migration may need to skip users marked as "Admin" or, before migration, remove Admin role from users (other than the Foreman default user admin).

Related issues 3 (1 open — 2 closed)

Actions

Copy link

Updated by Dominic Cleal almost 10 years ago

Blocks Tracker #4552: New permissions/authorization system issues added

Actions

Copy link

Updated by Dominic Cleal almost 10 years ago

Category set to DB migrations

Actions

Copy link

Updated by Derek Wright almost 10 years ago

Also another note, when setting Admin on an individual user after the Upgrade to 1.5, their roles tab is no longer available. There is no way (that I can see in the UI) to remove admin privs from that user afterwards.

Actions

Copy link

Updated by Marek Hulán almost 10 years ago

Category changed from DB migrations to Users, Roles and Permissions
Status changed from New to Assigned
Assignee set to Marek Hulán
Target version set to 1.8.3

The problem is that we don't display form in case when we try to edit another admin user or we try to edit our own profile. Which is definitely a bug because there is no way to modify admin's permissions/orgs/locs. It's not related to new permissions, this was added in https://github.com/theforeman/foreman/pull/1191 not sure why yet. Is the correct behaviour to display it to anybody with :edit_users permission on a particular user maybe even if I'm editing myself?

Actions

Copy link