Project

General

Profile

Actions

Bug #5489

closed

Permission migration script can create invalid search conditions

Added by Marek Hulán almost 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Users, Roles and Permissions
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

after migration a user reported filters with search phrases like "(() or (compute_resource_id = 2))" which raises scoped search exceptions, we should go over the whole migration script and make sure we can't detect empty conditions


Related issues 1 (1 open0 closed)

Blocks Foreman - Tracker #4552: New permissions/authorization system issuesNew

Actions
Actions #1

Updated by Marek Hulán almost 10 years ago

  • Blocks Tracker #4552: New permissions/authorization system issues added
Actions #2

Updated by Marek Hulán almost 10 years ago

one clue (but worth of checking all condition generating)

the only users who had the incorrect search string syntax were ones that had ownership of more than one hostgroup

Actions #3

Updated by Dominic Cleal almost 10 years ago

  • Target version set to 1.8.3
  • translation missing: en.field_release set to 4
Actions #4

Updated by Dominic Cleal almost 10 years ago

  • Status changed from New to Assigned
  • Assignee set to Dominic Cleal
Actions #5

Updated by Dominic Cleal almost 10 years ago

To reproduce:

0. Use pre-#812 Foreman
1. Create a user with the "View hosts" role (#5540)
2. Edit the user, add two types of filter: a domain filter + a host group filter. Do not tick owned hosts.
3. Migrate to post-#812
4. Check the custom role + filter added, you'll see: (() or (domain_id = 1)) or (hostgroup_id = 1)

Actions #6

Updated by Dominic Cleal almost 10 years ago

  • Status changed from Assigned to Ready For Testing
Actions #7

Updated by Dominic Cleal almost 10 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF