Project

General

Profile

Actions

Bug #4519

closed

Renaming host with / in name causes "No route matches" error

Added by Dominic Cleal about 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

1. Edit an existing host
2. Change name to "foo/bar" (or add a "/" inside the name)
3. Submit form

You receive the following error:

No route matches {:action=>"toggle_manage", :controller=>"hosts", :id=>"foo/bar.example.com"}

The save doesn't occur as the name is invalid (since #3697), but the form fails to re-render.


Related issues 3 (0 open3 closed)

Related to Foreman - Bug #3697: Field Validations Should be more ComprehensiveClosedStephen Benjamin11/20/2013Actions
Related to Foreman - Bug #4456: CVE-2014-0089 - Stored Cross Site Scripting (XSS) on 500 error pageClosedJoseph Magen02/26/201403/18/2014Actions
Related to Foreman - Bug #9531: Removing host name from Host#edit throws routing errorClosedTomer Brisker02/24/2015Actions
Actions #1

Updated by Dominic Cleal about 10 years ago

  • Related to Bug #3697: Field Validations Should be more Comprehensive added
Actions #2

Updated by Dominic Cleal about 10 years ago

  • Related to Bug #4456: CVE-2014-0089 - Stored Cross Site Scripting (XSS) on 500 error page added
Actions #3

Updated by Dominic Cleal about 10 years ago

This issue is marked as private, not because of a particular security angle, but because it's possible to include JavaScript in the host name, which thanks to #4456 gets rendered in the user's browser. Once #4456 is fixed, I'll make this issue public.

Actions #4

Updated by Dominic Cleal about 10 years ago

  • Category changed from Security to Web Interface
  • Private changed from Yes to No
Actions #5

Updated by Dominic Cleal about 8 years ago

  • Related to Bug #9531: Removing host name from Host#edit throws routing error added
Actions #6

Updated by The Foreman Bot about 7 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Tomer Brisker
  • Pull request https://github.com/theforeman/foreman/pull/4179 added
Actions #7

Updated by Anonymous about 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #8

Updated by Dominic Cleal about 7 years ago

  • translation missing: en.field_release set to 210
Actions #9

Updated by Daniel Lobato Garcia about 7 years ago

  • Target version set to 169
Actions #10

Updated by Brad Buckingham about 7 years ago

  • Target version deleted (169)
Actions #11

Updated by Daniel Lobato Garcia about 7 years ago

  • Target version set to 1.11.0
Actions

Also available in: Atom PDF