Bug #398

domain wrong if host contians a '.'

Added by Matt Moran over 7 years ago. Updated over 7 years ago.

Status:Closed
Priority:Normal
Assigned To:Ohad Levy
Category:Host creation
Target version:0.1-6
Difficulty: Bugzilla link:
Found in release: Pull request:
Story points-
Velocity based estimate-

Description

http://github.com/ohadlevy/foreman/blob/develop/app/models/host.rb#L451

If host = 'xx-01.xx-02' then the domain will be 'xx-02.mydomain.com' and not 'mydomain.com'

0001-fixes-bug-398-issue-with-adding-hosts-with-full-stop.patch Magnifier (2.23 KB) Matt Moran, 10/04/2010 02:05 PM

Associated revisions

Revision 61dc8cee
Added by Matt Moran over 7 years ago

fixes bug #398 - issue with adding hosts with full stops
This introduce a small behaviour change, before, once adding host like:
x.domain.net, foreman would automatically add domain.net to its domain
list, but now, as a full stop(".") is a valid hostname char,
we can't parse the domain name safely, therefor we expect the user to
make sure that the domain created before creating a host.

History

#2 Updated by Matt Moran over 7 years ago

Here's my patch.

#3 Updated by Ohad Levy over 7 years ago

  • Status changed from New to Ready For Testing
  • Target version set to 0.1-6
  • % Done changed from 0 to 100

#4 Updated by Matt Moran over 7 years ago

Pulled update. Tested okay.

#5 Updated by Ohad Levy over 7 years ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF