Project

General

Profile

Actions

Feature #36984

closed

Exclude all subdirectories for vendor in .rubocop.yaml

Added by dosas please_edit_me 5 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

I stumbled upon this problem when executing rubocop for foreman_ansible locally and in gitlab ci
https://github.com/rubocop/rubocop/issues/9832

Change the line here
https://github.com/theforeman/foreman_ansible/blob/master/.rubocop.yml#L16

from
```
'vendor/bundle/**/*'
```
to

```
'vendor/**/*'
```

This would be the same as in the default config: https://github.com/rubocop/rubocop/blob/master/config/default.yml#L68

Actions #1

Updated by dosas please_edit_me 5 months ago

  • Tracker changed from Bug to Feature
  • Description updated (diff)
Actions #2

Updated by The Foreman Bot 4 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_ansible/pull/677 added
Actions #3

Updated by The Foreman Bot 4 months ago

  • Fixed in Releases foreman_ansible-13.0.0 added
Actions #4

Updated by dosas please_edit_me 4 months ago

  • Status changed from Ready For Testing to Closed
Actions #5

Updated by Nofar Alfassi 3 months ago

  • Fixed in Releases foreman_ansible-13.0.3 added
  • Fixed in Releases deleted (foreman_ansible-13.0.0)
Actions

Also available in: Atom PDF