Bug #30148
closed
Incremental restore still drops databases
Description
Full restore should drop the databases first. Incremental restore should keep the current databases and apply the changes. Running `foreman-maintain restore -i` will drop the databases (according to code and prompt).
Updated by The Foreman Bot almost 4 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman_maintain/pull/360 added
Updated by Lance Dillon almost 4 years ago
From irc chat:
looking through the code, it looks like the only portion of backup that has the incremental code is metadata....but you specify incremental for the whole backup
so you run full backup, which does a full of everything (of course)
then incremental, which runs a full backup of dbs, but incremental of metadata
so when you do a restore of full, it of course wipes current data (drops dbs and stuff), and does the full restore
but then you do an incremental restore...but since dbs are full, and only metadata is incremental, it drops dbs again and does a full restore of db data, and incremental restore of metadata
that doesnt seem very efficient, especially since the db data dwarfs the size of the metadata
seems like either everything should support incremental, or not even bother...
in this case since incremental postgres is not easy, i would vote for removing incremental entirely
Updated by Eric Helms 3 months ago
- Status changed from Ready For Testing to Rejected