Project

General

Profile

Actions

Bug #30094

closed

Unnecessary options present in subcommands of "foreman-maintain packages" command.

Added by Suraj Patil almost 4 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1734766

Description of problem:
Unnecessary options present in subcommands of "foreman-maintain packages" command.
Version-Release number of selected component (if applicable):
- Satellite 6.6.0 snap 13
- rubygem-foreman_maintain-0.4.5-1.el7sat.noarch

How reproducible:
always

Steps to Reproduce:
1. Run "foreman-maintain packages lock --help"
2. Run "foreman-maintain packages unlock --help"
3. Run "foreman-maintain packages is-locked --help"
4. Run "foreman-maintain packages status --help"

Actual results:

[root@hpe-dl380egen8-01 ~]# foreman-maintain packages lock --help
Usage:
foreman-maintain packages lock [OPTIONS]

Options:
-y, --assumeyes Automatically answer yes for all questions
-w, --whitelist whitelist Comma-separated list of labels of steps to be skipped
-f, --force Force steps that would be skipped as they were already run
-h, --help print help
[root@hpe-dl380egen8-01 ~]# foreman-maintain packages unlock --help
Usage:
foreman-maintain packages unlock [OPTIONS]

Options:
-y, --assumeyes Automatically answer yes for all questions
-w, --whitelist whitelist Comma-separated list of labels of steps to be skipped
-f, --force Force steps that would be skipped as they were already run
-h, --help print help
[root@hpe-dl380egen8-01 ~]# foreman-maintain packages is-locked --help
Usage:
foreman-maintain packages is-locked [OPTIONS]

Options:
-y, --assumeyes Automatically answer yes for all questions
-w, --whitelist whitelist Comma-separated list of labels of steps to be skipped
-f, --force Force steps that would be skipped as they were already run
-h, --help print help
[root@hpe-dl380egen8-01 ~]# foreman-maintain packages status --help
Usage:
foreman-maintain packages status [OPTIONS]

Options:
-y, --assumeyes Automatically answer yes for all questions
-w, --whitelist whitelist Comma-separated list of labels of steps to be skipped
-f, --force Force steps that would be skipped as they were already run
-h, --help print help

Expected results:

[root@hpe-dl380egen8-01 ~]# foreman-maintain packages lock --help
Usage:
foreman-maintain packages lock [OPTIONS]

Options:
-y, --assumeyes Automatically answer yes for all questions
-h, --help print help
[root@hpe-dl380egen8-01 ~]# foreman-maintain packages unlock --help
Usage:
foreman-maintain packages unlock [OPTIONS]

Options:
-y, --assumeyes Automatically answer yes for all questions
-h, --help print help
[root@hpe-dl380egen8-01 ~]# foreman-maintain packages is-locked --help
Usage:
foreman-maintain packages is-locked [OPTIONS]

Options:
-y, --assumeyes Automatically answer yes for all questions
-h, --help print help
[root@hpe-dl380egen8-01 ~]# foreman-maintain packages status --help
Usage:
foreman-maintain packages status [OPTIONS]

Options:
-y, --assumeyes Automatically answer yes for all questions
-h, --help print help

Additional info:
- [RFE] Implement a yum version lock type of protections against upgrades https://bugzilla.redhat.com/show_bug.cgi?id=1512600
- --force and --whitelist options seems unnecessary here.


Related issues 1 (0 open1 closed)

Related to Foreman Maintain - Feature #30084: [RFE] Get control over interactive_option.ClosedSuraj PatilActions
Actions #1

Updated by Suraj Patil almost 4 years ago

  • Related to Feature #30084: [RFE] Get control over interactive_option. added
Actions #2

Updated by The Foreman Bot almost 3 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_maintain/pull/490 added
Actions #3

Updated by Amit Upadhye almost 3 years ago

  • Status changed from Ready For Testing to Closed
Actions #4

Updated by The Foreman Bot almost 3 years ago

  • Pull request https://github.com/theforeman/foreman_maintain/pull/505 added
Actions

Also available in: Atom PDF