Refactor #260: Switch family implemetation to use STI - Foreman

Actions

Copy link

Refactor #260

closed

Switch family implemetation to use STI

Added by Paul Kelly almost 14 years ago. Updated almost 14 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Paul Kelly

Category:

Rails

Target version:

0.1-6

Difficulty:

Triaged:

Bugzilla link:

Pull request:

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

The home grown class inheritance stuff in family is confusing.
Switch to using a set of classes based upon the Operatingsystem

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Paul Kelly almost 14 years ago

Status changed from New to Feedback
Branch set to refactor/260-family-with-sti

Actions

Copy link

Updated by Paul Kelly almost 14 years ago

By adding a 'type' field to the operatingsystem record and then managing this field manually we can make Rails cast the record to the required family class.

Actions

Copy link

Updated by Ohad Levy almost 14 years ago

Target version set to 0.1-6

Actions

Copy link

Updated by Paul Kelly almost 14 years ago

Fixed for 1.5
Tests work

Actions

Copy link

Updated by Paul Kelly almost 14 years ago

Added OS before_filter to deduce the family, if not set
OS DB entries can now contain a null type
@@families promoted to Operatingsystem::FAMILIES
Included mods suggested by Ohad

Actions

Copy link

Updated by Paul Kelly almost 14 years ago

Rebased
Centralized Family name and os membership list into a single hash
Added test in unattended controller that detects if a os has no family
simplified deduce_family
tests pass

Actions

Copy link