Project

General

Profile

Actions
Copy link

Bug #23658

closed

Foreman Salt Plugin 10.0 upload-salt-reports error with Foreman 1.17

Added by Nathan Grennan about 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
High
Assignee:
Greg Sutcliffe
Category:
API
Target version:
10.1.0
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman_salt/pull/79
Fixed in Releases:
Found in Releases:
10.0 (or older)
Red Hat JIRA:

Description

I installed the Foreman Salt Plugin 10.0 with Foreman 1.17, but get the error below. I also tried 8.0.4 and 9.0.1, same error. I downgraded to Foreman 1.16 with Foreman Salt Plugin 9.0.1, and it works.

upload-salt-reports:
Unable to upload job - aborting report upload {
"error": {"message":"unable to convert unpermitted parameters to hash"}
}

I lost the backtrace on reinstall, it pointed to line 25 in the code below.

app/controllers/foreman_salt/api/v2/jobs_controller.rb:
Rails.logger.info("Processing job #{params[:job][:job_id]} from Salt.")
case params[:job][:function]
when 'state.highstate'
--> task = ForemanTasks.async_task(::Actions::ForemanSalt::ReportImport, params[:job], detected_proxy.try(:id))
render :json => { :task_id => task.id }
else
render :json => { :message => 'Unsupported function' }, :status => :unprocessable_entity

Related issues 1 (0 open — 1 closed)

Related to Salt - Bug #24133: Rails 5.1 error when submitting salt report: "unable to convert unpermitted parameters to hash (ActionController::UnfilteredParameters)"ClosedGreg Sutcliffe07/02/2018Actions
Actions
Copy link
 #1

Updated by Nathan Grennan about 6 years ago

  • Subject changed from Foreman Salt Plugin 10.0 with Foreman 1.17 to Foreman Salt Plugin 10.0 upload-salt-reports error with Foreman 1.17
Actions
Copy link
 #2

Updated by Nathan Grennan about 6 years ago

Found a backtrace I had saved in pastebin:

2018-05-18T23:02:04 0ea272ea [background] [E] unable to convert unpermitted parameters to hash (ActionController::UnfilteredParameters)
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_controller/metal/strong_parameters.rb:265:in `to_h'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_controller/metal/strong_parameters.rb:282:in `to_hash'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/serializable.rb:50:in `recursive_to_hash'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/serializable.rb:46:in `block in recursive_to_hash'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/serializable.rb:46:in `each'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/serializable.rb:46:in `inject'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/serializable.rb:46:in `recursive_to_hash'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/action.rb:561:in `check_serializable'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/action.rb:503:in `block in execute_plan'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/action.rb:444:in `block in with_error_handling'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/action.rb:444:in `catch'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/action.rb:444:in `with_error_handling'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/action.rb:483:in `execute_plan'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/action.rb:277:in `execute'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/execution_plan/steps/plan_step.rb:54:in `block in execute'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/execution_plan/steps/abstract.rb:155:in `with_meta_calculation'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/execution_plan/steps/plan_step.rb:53:in `execute'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/execution_plan.rb:270:in `block (2 levels) in plan'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/execution_plan.rb:368:in `switch_flow'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/execution_plan.rb:358:in `with_planning_scope'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/execution_plan.rb:269:in `block in plan'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware/stack.rb:26:in `pass'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware.rb:18:in `pass'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware.rb:43:in `plan_phase'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware/stack.rb:22:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware/stack.rb:26:in `pass'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware.rb:18:in `pass'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware.rb:43:in `plan_phase'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware/stack.rb:22:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware/stack.rb:26:in `pass'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware.rb:18:in `pass'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware/common/transaction.rb:16:in `block in rollback_on_error'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activerecord-5.1.4/lib/active_record/connection_adapters/abstract/database_statements.rb:235:in `block in transaction'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activerecord-5.1.4/lib/active_record/connection_adapters/abstract/transaction.rb:194:in `block in within_new_transaction'
 | /usr/lib/ruby/2.3.0/monitor.rb:214:in `mon_synchronize'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activerecord-5.1.4/lib/active_record/connection_adapters/abstract/transaction.rb:191:in `within_new_transaction'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activerecord-5.1.4/lib/active_record/connection_adapters/abstract/database_statements.rb:235:in `transaction'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activerecord-5.1.4/lib/active_record/transactions.rb:210:in `transaction'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/transaction_adapters/active_record.rb:5:in `transaction'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware/common/transaction.rb:15:in `rollback_on_error'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware/common/transaction.rb:5:in `plan_phase'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware/stack.rb:22:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware/world.rb:30:in `execute'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/execution_plan.rb:268:in `plan'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/world.rb:174:in `block in plan'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/world.rb:172:in `tap'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/world.rb:172:in `plan'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/world.rb:148:in `trigger'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/foreman-tasks-0.11.2/lib/foreman_tasks.rb:19:in `trigger'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/foreman-tasks-0.11.2/lib/foreman_tasks.rb:25:in `block in trigger_task'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/foreman-tasks-0.11.2/lib/foreman_tasks.rb:39:in `block in rails_safe_trigger_task'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/dependencies/interlock.rb:46:in `block in permit_concurrent_loads'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/concurrency/share_lock.rb:185:in `yield_shares'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/dependencies/interlock.rb:45:in `permit_concurrent_loads'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/foreman-tasks-0.11.2/lib/foreman_tasks.rb:38:in `rails_safe_trigger_task'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/foreman-tasks-0.11.2/lib/foreman_tasks.rb:23:in `trigger_task'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/foreman-tasks-0.11.2/lib/foreman_tasks.rb:47:in `async_task'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/foreman_salt-10.0.0/app/controllers/foreman_salt/api/v2/jobs_controller.rb:25:in `upload'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_controller/metal/basic_implicit_render.rb:4:in `send_action'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/abstract_controller/base.rb:186:in `process_action'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_controller/metal/rendering.rb:30:in `process_action'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/abstract_controller/callbacks.rb:20:in `block in process_action'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/callbacks.rb:108:in `block in run_callbacks'
 | /usr/share/foreman/app/controllers/api/v2/base_controller.rb:152:in `disable_json_root'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/callbacks.rb:117:in `block in run_callbacks'
 | /usr/share/foreman/app/controllers/concerns/application_shared.rb:15:in `set_timezone'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/callbacks.rb:117:in `block in run_callbacks'
 | /usr/share/foreman/app/models/concerns/foreman/thread_session.rb:32:in `clear_thread'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/callbacks.rb:117:in `block in run_callbacks'
 | /usr/share/foreman/app/controllers/concerns/foreman/controller/topbar_sweeper.rb:12:in `set_topbar_sweeper_controller'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/callbacks.rb:117:in `block in run_callbacks'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/audited-4.5.0/lib/audited/sweeper.rb:14:in `around'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/callbacks.rb:117:in `block in run_callbacks'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/audited-4.5.0/lib/audited/sweeper.rb:14:in `around'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/callbacks.rb:117:in `block in run_callbacks'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/callbacks.rb:135:in `run_callbacks'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/abstract_controller/callbacks.rb:19:in `process_action'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_controller/metal/rescue.rb:20:in `process_action'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_controller/metal/instrumentation.rb:32:in `block in process_action'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/notifications.rb:166:in `block in instrument'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/notifications/instrumenter.rb:21:in `instrument'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/notifications.rb:166:in `instrument'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_controller/metal/instrumentation.rb:30:in `process_action'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_controller/metal/params_wrapper.rb:252:in `process_action'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activerecord-5.1.4/lib/active_record/railties/controller_runtime.rb:22:in `process_action'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/abstract_controller/base.rb:124:in `process'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionview-5.1.4/lib/action_view/rendering.rb:30:in `process'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_controller/metal.rb:189:in `dispatch'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_controller/metal.rb:253:in `dispatch'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/routing/route_set.rb:49:in `dispatch'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/routing/route_set.rb:31:in `serve'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/routing/mapper.rb:16:in `block in <class:Constraints>'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/routing/mapper.rb:46:in `serve'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/journey/router.rb:50:in `block in serve'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/journey/router.rb:33:in `each'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/journey/router.rb:33:in `serve'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/routing/route_set.rb:834:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/apipie-rails-0.5.7/lib/apipie/static_dispatcher.rb:65:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/apipie-rails-0.5.7/lib/apipie/extractor/recorder.rb:136:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/apipie-rails-0.5.7/lib/apipie/middleware/checksum_in_headers.rb:27:in `call'
 | /usr/share/foreman/lib/middleware/catch_json_parse_errors.rb:8:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/rack-2.0.4/lib/rack/etag.rb:25:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/rack-2.0.4/lib/rack/conditional_get.rb:38:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/rack-2.0.4/lib/rack/head.rb:12:in `call'
 | /usr/share/foreman/lib/middleware/session_safe_logging.rb:17:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/rack-2.0.4/lib/rack/session/abstract/id.rb:232:in `context'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/rack-2.0.4/lib/rack/session/abstract/id.rb:226:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/middleware/cookies.rb:613:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/middleware/callbacks.rb:26:in `block in call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/callbacks.rb:97:in `run_callbacks'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/middleware/callbacks.rb:24:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/middleware/debug_exceptions.rb:59:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/middleware/show_exceptions.rb:31:in `call'
2018-05-18T23:02:04 0ea272ea [background] [E] unable to convert unpermitted parameters to hash (ActionController::UnfilteredParameters)
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_controller/metal/strong_parameters.rb:265:in `to_h'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_controller/metal/strong_parameters.rb:282:in `to_hash'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/serializable.rb:50:in `recursive_to_hash'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/serializable.rb:46:in `block in recursive_to_hash'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/serializable.rb:46:in `each'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/serializable.rb:46:in `inject'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/serializable.rb:46:in `recursive_to_hash'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/action.rb:561:in `check_serializable'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/action.rb:503:in `block in execute_plan'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/action.rb:444:in `block in with_error_handling'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/action.rb:444:in `catch'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/action.rb:444:in `with_error_handling'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/action.rb:483:in `execute_plan'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/action.rb:277:in `execute'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/execution_plan/steps/plan_step.rb:54:in `block in execute'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/execution_plan/steps/abstract.rb:155:in `with_meta_calculation'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/execution_plan/steps/plan_step.rb:53:in `execute'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/execution_plan.rb:270:in `block (2 levels) in plan'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/execution_plan.rb:368:in `switch_flow'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/execution_plan.rb:358:in `with_planning_scope'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/execution_plan.rb:269:in `block in plan'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware/stack.rb:26:in `pass'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware.rb:18:in `pass'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware.rb:43:in `plan_phase'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware/stack.rb:22:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware/stack.rb:26:in `pass'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware.rb:18:in `pass'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware.rb:43:in `plan_phase'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware/stack.rb:22:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware/stack.rb:26:in `pass'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware.rb:18:in `pass'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware/common/transaction.rb:16:in `block in rollback_on_error'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activerecord-5.1.4/lib/active_record/connection_adapters/abstract/database_statements.rb:235:in `block in transaction'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activerecord-5.1.4/lib/active_record/connection_adapters/abstract/transaction.rb:194:in `block in within_new_transaction'
 | /usr/lib/ruby/2.3.0/monitor.rb:214:in `mon_synchronize'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activerecord-5.1.4/lib/active_record/connection_adapters/abstract/transaction.rb:191:in `within_new_transaction'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activerecord-5.1.4/lib/active_record/connection_adapters/abstract/database_statements.rb:235:in `transaction'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activerecord-5.1.4/lib/active_record/transactions.rb:210:in `transaction'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/transaction_adapters/active_record.rb:5:in `transaction'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware/common/transaction.rb:15:in `rollback_on_error'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware/common/transaction.rb:5:in `plan_phase'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware/stack.rb:22:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/middleware/world.rb:30:in `execute'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/execution_plan.rb:268:in `plan'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/world.rb:174:in `block in plan'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/world.rb:172:in `tap'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/world.rb:172:in `plan'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/dynflow-0.8.37/lib/dynflow/world.rb:148:in `trigger'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/foreman-tasks-0.11.2/lib/foreman_tasks.rb:19:in `trigger'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/foreman-tasks-0.11.2/lib/foreman_tasks.rb:25:in `block in trigger_task'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/foreman-tasks-0.11.2/lib/foreman_tasks.rb:39:in `block in rails_safe_trigger_task'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/dependencies/interlock.rb:46:in `block in permit_concurrent_loads'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/concurrency/share_lock.rb:185:in `yield_shares'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/dependencies/interlock.rb:45:in `permit_concurrent_loads'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/foreman-tasks-0.11.2/lib/foreman_tasks.rb:38:in `rails_safe_trigger_task'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/foreman-tasks-0.11.2/lib/foreman_tasks.rb:23:in `trigger_task'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/foreman-tasks-0.11.2/lib/foreman_tasks.rb:47:in `async_task'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/foreman_salt-10.0.0/app/controllers/foreman_salt/api/v2/jobs_controller.rb:25:in `upload'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_controller/metal/basic_implicit_render.rb:4:in `send_action'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/abstract_controller/base.rb:186:in `process_action'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_controller/metal/rendering.rb:30:in `process_action'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/abstract_controller/callbacks.rb:20:in `block in process_action'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/callbacks.rb:108:in `block in run_callbacks'
 | /usr/share/foreman/app/controllers/api/v2/base_controller.rb:152:in `disable_json_root'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/callbacks.rb:117:in `block in run_callbacks'
 | /usr/share/foreman/app/controllers/concerns/application_shared.rb:15:in `set_timezone'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/callbacks.rb:117:in `block in run_callbacks'
 | /usr/share/foreman/app/models/concerns/foreman/thread_session.rb:32:in `clear_thread'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/callbacks.rb:117:in `block in run_callbacks'
 | /usr/share/foreman/app/controllers/concerns/foreman/controller/topbar_sweeper.rb:12:in `set_topbar_sweeper_controller'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/callbacks.rb:117:in `block in run_callbacks'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/audited-4.5.0/lib/audited/sweeper.rb:14:in `around'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/callbacks.rb:117:in `block in run_callbacks'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/audited-4.5.0/lib/audited/sweeper.rb:14:in `around'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/callbacks.rb:117:in `block in run_callbacks'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/callbacks.rb:135:in `run_callbacks'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/abstract_controller/callbacks.rb:19:in `process_action'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_controller/metal/rescue.rb:20:in `process_action'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_controller/metal/instrumentation.rb:32:in `block in process_action'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/notifications.rb:166:in `block in instrument'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/notifications/instrumenter.rb:21:in `instrument'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/notifications.rb:166:in `instrument'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_controller/metal/instrumentation.rb:30:in `process_action'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_controller/metal/params_wrapper.rb:252:in `process_action'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activerecord-5.1.4/lib/active_record/railties/controller_runtime.rb:22:in `process_action'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/abstract_controller/base.rb:124:in `process'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionview-5.1.4/lib/action_view/rendering.rb:30:in `process'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_controller/metal.rb:189:in `dispatch'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_controller/metal.rb:253:in `dispatch'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/routing/route_set.rb:49:in `dispatch'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/routing/route_set.rb:31:in `serve'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/routing/mapper.rb:16:in `block in <class:Constraints>'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/routing/mapper.rb:46:in `serve'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/journey/router.rb:50:in `block in serve'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/journey/router.rb:33:in `each'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/journey/router.rb:33:in `serve'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/routing/route_set.rb:834:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/apipie-rails-0.5.7/lib/apipie/static_dispatcher.rb:65:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/apipie-rails-0.5.7/lib/apipie/extractor/recorder.rb:136:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/apipie-rails-0.5.7/lib/apipie/middleware/checksum_in_headers.rb:27:in `call'
 | /usr/share/foreman/lib/middleware/catch_json_parse_errors.rb:8:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/rack-2.0.4/lib/rack/etag.rb:25:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/rack-2.0.4/lib/rack/conditional_get.rb:38:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/rack-2.0.4/lib/rack/head.rb:12:in `call'
 | /usr/share/foreman/lib/middleware/session_safe_logging.rb:17:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/rack-2.0.4/lib/rack/session/abstract/id.rb:232:in `context'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/rack-2.0.4/lib/rack/session/abstract/id.rb:226:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/middleware/cookies.rb:613:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/middleware/callbacks.rb:26:in `block in call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/callbacks.rb:97:in `run_callbacks'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/middleware/callbacks.rb:24:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/middleware/debug_exceptions.rb:59:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/middleware/show_exceptions.rb:31:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/railties-5.1.4/lib/rails/rack/logger.rb:36:in `call_app'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/railties-5.1.4/lib/rails/rack/logger.rb:26:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/sprockets-rails-3.2.1/lib/sprockets/rails/quiet_assets.rb:13:in `call'
 | /usr/share/foreman/lib/middleware/tagged_logging.rb:18:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/middleware/remote_ip.rb:79:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/middleware/request_id.rb:25:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/rack-2.0.4/lib/rack/method_override.rb:22:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/rack-2.0.4/lib/rack/runtime.rb:22:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/activesupport-5.1.4/lib/active_support/cache/strategy/local_cache_middleware.rb:27:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/middleware/executor.rb:12:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/actionpack-5.1.4/lib/action_dispatch/middleware/static.rb:125:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/rack-2.0.4/lib/rack/sendfile.rb:111:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/secure_headers-3.7.3/lib/secure_headers/middleware.rb:12:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/railties-5.1.4/lib/rails/engine.rb:522:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/railties-5.1.4/lib/rails/railtie.rb:185:in `public_send'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/railties-5.1.4/lib/rails/railtie.rb:185:in `method_missing'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/rack-2.0.4/lib/rack/urlmap.rb:68:in `block in call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/rack-2.0.4/lib/rack/urlmap.rb:53:in `each'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/rack-2.0.4/lib/rack/urlmap.rb:53:in `call'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/rack-2.0.4/lib/rack/handler/webrick.rb:86:in `service'
 | /usr/lib/ruby/2.3.0/webrick/httpserver.rb:140:in `service'
 | /usr/lib/ruby/2.3.0/webrick/httpserver.rb:96:in `run'
 | /usr/lib/ruby/2.3.0/webrick/server.rb:296:in `block in start_thread'
 | /usr/share/foreman/vendor/ruby/2.3.0/gems/logging-2.2.2/lib/logging/diagnostic_context.rb:474:in `block in create_with_logging_context'

Actions
Copy link
 #3

Updated by Ondřej Pražák almost 6 years ago

Hi, thanks for the backtrace, it will be useful. Unfortunately, foreman_salt needs a new maintainer so I cannot tell when this will be fixed. There is a Discourse thread about it.

Actions
Copy link
 #4

Updated by Greg Sutcliffe almost 6 years ago

  • Category set to API
  • Status changed from New to Assigned
  • Assignee set to Greg Sutcliffe
  • Priority changed from Normal to High

I'm digging into this for my own Salt setup. This should allow a single import:

--- app/controllers/foreman_salt/api/v2/jobs_controller.rb.orij    2018-06-25 21:23:50.425522920 +0000
+++ app/controllers/foreman_salt/api/v2/jobs_controller.rb    2018-06-25 21:23:48.711546489 +0000
@@ -19,7 +19,6 @@
         param_group :job, :as => :upload

     def upload
+      params[:job].permit!
       Rails.logger.info("Processing job #{params[:job][:job_id]} from Salt.")
       Rails.logger.debug("GSS: #{params.inspect}")
       case params[:job][:function]

Unfortunately the upload-salt-reports script then bombs on a bad status return, still looking into that. Nathan, let me know if that helps, I can send a PR if so

Actions
Copy link
 #5

Updated by Greg Sutcliffe almost 6 years ago

  • Status changed from Assigned to Closed
  • Triaged set to No
  • Pull request https://github.com/theforeman/foreman_salt/pull/79 added

Should be fixed in master, new release of Salt plugin will be out shortly

Actions
Copy link
 #6

Updated by Greg Sutcliffe almost 6 years ago

  • Related to Bug #24133: Rails 5.1 error when submitting salt report: "unable to convert unpermitted parameters to hash (ActionController::UnfilteredParameters)" added
Actions
Copy link
 #7

Updated by Greg Sutcliffe almost 6 years ago

  • Target version set to 10.1.0
  • Found in Releases 10.0 (or older) added
Actions
Copy link
 #8

Updated by Greg Sutcliffe almost 6 years ago

  • Triaged changed from No to Yes
Actions
Copy link

Also available in: Atom PDF