Bug #22651: ISC DHCP config parser ignores 'include' within 'shared_network' - Smart Proxy - Foreman

Actions

Copy link

Bug #22651

closed

ISC DHCP config parser ignores 'include' within 'shared_network'

Added by Dan Ports about 6 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

DHCP

Target version:

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/smart-proxy/pull/568

Fixed in Releases:

Found in Releases:

Foreman - 1.16.0

Red Hat JIRA:

Description

I was getting errors of the following form when trying to perform any DHCP operation:

ERROR -- : No Subnet detected for: 10.100.1.0

After debugging this for a bit, it seems that the problem is that my dhcpd.conf looks like:

shared-network syslab {
  include "/etc/dhcp/subnets/10.100.0.0.conf";
  include "/etc/dhcp/subnets/10.100.1.0.conf";
  include "/etc/dhcp/subnets/10.100.2.0.conf";
  include "/etc/dhcp/subnets/10.100.3.0.conf";
  include "/etc/dhcp/subnets/10.100.5.0.conf";
}

(where the referenced files contain pretty standard subnet declarations)

The ISC configuration_parser only processes include_file directives at the top level, so it was ignoring the includes and missing the subnet declarations, causing the DHCP plugin to be unable to detect any subnets.