Project

General

Profile

Actions

Bug #21127

closed

Scap content file is printed into logs

Added by Ondřej Pražák over 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

Debug logger logs the response body. When scap content is downloaded via hammer, the response is the file itself, so the entire scap content file ends up in the logs. Because it only clutters the logs and does not contain any relevant debugging information, I think we should skip logging response body for download actions. This goes for tailoring files as well.

Steps to reproduce:
1) Download scap content using hammer/api


Files

download-scap-content.png View download-scap-content.png 194 KB Ondřej Pražák, 09/27/2017 08:28 AM

Related issues 1 (1 open0 closed)

Related to Foreman - Bug #25482: Excessive logging of OpenScap report via Rails Ready For TestingLukas ZapletalActions
Actions #1

Updated by Marek Hulán over 6 years ago

luckily we don't log debug messages in production, I agree we should just silence response body for download actions

Actions #2

Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ondřej Pražák
  • Pull request https://github.com/theforeman/foreman_openscap/pull/357 added
Actions #3

Updated by Marek Hulán over 5 years ago

  • Target version set to foreman_openscap 0.11.0
  • Fixed in Releases foreman_openscap 0.11.0 added
Actions #4

Updated by Ondřej Pražák over 5 years ago

  • Status changed from Ready For Testing to Closed
Actions #5

Updated by Lukas Zapletal over 5 years ago

  • Bugzilla link set to 1650543
Actions #6

Updated by Lukas Zapletal over 5 years ago

  • Bugzilla link deleted (1650543)

The BZ 1650543 is somehow related but a different bug actually.

Actions #7

Updated by Lukas Zapletal over 5 years ago

  • Related to Bug #25482: Excessive logging of OpenScap report via Rails added
Actions

Also available in: Atom PDF