Project

General

Profile

Actions
Copy link

Refactor #21036

closed

Don't use class as class_name in associations

Added by Anonymous over 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Rails
Target version:
1.17.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/4862
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Related issues 3 (1 open — 2 closed)

Related to Foreman - Refactor #20956: Passing a class as a value in an Active Record query is deprecatedClosed09/16/2017Actions
Related to Docker - Bug #23019: Don't pass class object to :class_name in relationsReady For TestingStephen Benjamin03/26/2018Actions
Blocks Foreman - Tracker #20948: Rails 5.1 upgrade tasksClosed09/16/2017

Actions
Actions
Copy link
 #1

Updated by Anonymous over 6 years ago

Actions
Copy link
 #2

Updated by Anonymous over 6 years ago

  • Subject changed from Don't use class name in associations to Don't use class as class_name in associations
Actions
Copy link
 #3

Updated by Anonymous over 6 years ago

  • Related to Refactor #20956: Passing a class as a value in an Active Record query is deprecated added
Actions
Copy link
 #4

Updated by Anonymous over 6 years ago

Rails 5.1 says:

Passing a class to the `class_name` is deprecated and will raise an ArgumentError in Rails 5.2.
It eagerloads more classes than necessary and potentially creates circular dependencies.
Please pass the class name as a string.

Actions
Copy link
 #5

Updated by The Foreman Bot over 6 years ago

  • Pull request https://github.com/theforeman/foreman/pull/4862 added
Actions
Copy link
 #6

Updated by Anonymous over 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #7

Updated by Stephen Benjamin about 6 years ago

  • Related to Bug #23019: Don't pass class object to :class_name in relations added
Actions
Copy link

Also available in: Atom PDF