Project

General

Profile

Actions
Copy link

Bug #20890

closed

SSH key validations should return better messages

Added by Tomáš Strachota over 6 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Shira Maximov
Category:
Users, Roles and Permissions
Target version:
1.17.0
Difficulty:
trivial
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/4834
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Creating an ssh key with invalid format results in following two messages:

Key is invalid
Key is invalid

It's caused by ssh_key and format validators:
https://github.com/theforeman/foreman/blob/develop/app/models/ssh_key.rb#L23-L24

The error messages should contain more information:

Key is not a valid public ssh key.
Key must be in OpenSSH public key format.

Actions
Copy link
 #1

Updated by Shira Maximov over 6 years ago

  • Status changed from New to Assigned
  • Assignee set to Shira Maximov
Actions
Copy link
 #2

Updated by The Foreman Bot over 6 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4834 added
Actions
Copy link
 #3

Updated by Marek Hulán over 6 years ago

  • translation missing: en.field_release set to 296
Actions
Copy link
 #4

Updated by Anonymous over 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #5

Updated by Tomer Brisker almost 4 years ago

  • Category changed from 218 to Users, Roles and Permissions
Actions
Copy link

Also available in: Atom PDF