Project

General

Profile

Actions

Bug #20622

closed

Puppet reports recalculate all statuses

Added by Lukas Zapletal over 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Category:
Importers
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

It appears that puppet reports cause all statuses to be updated:

https://github.com/theforeman/foreman/blob/develop/app/services/report_importer.rb#L42

On a heavily loaded system this could mean this is being called 100s of times per second. This is a fairly slow operation to be doing when not necessary.

Puppet reports should only refresh statuses that are relevant to them.

Actions #1

Updated by Marek Hulán over 6 years ago

I agree, Host::Managed#refresh_statuses is being used from many places (report import, openscap report import and I can imagine other plugins too). Maybe it should accept set of statuses that were changed and should be refreshed. Btw Justin was looking into this recently too.

Actions #2

Updated by The Foreman Bot over 6 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Lukas Zapletal
  • Pull request https://github.com/theforeman/foreman/pull/4749 added
Actions #3

Updated by Lukas Zapletal over 6 years ago

  • translation missing: en.field_release set to 287

Requesting 1.15 as well.

Actions #4

Updated by Lukas Zapletal over 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF