Actions
Bug #19630
closed
Notifications are being created for internal admins
Difficulty:
Triaged:
Description
If notification audience is 'admin', the notification gets created for all admin accounts including internal anonymous and api admins. They won't be removed or read. The code that should be fixed is here https://github.com/theforeman/foreman/blob/1.15-stable/app/models/notification.rb#L47 it should probably add condition where.not(:login => [User::ANONYMOUS_ADMIN, User::ANONYMOUS_API_ADMIN])
EDIT: or simply add the scope "except_hidden"
Updated by The Foreman Bot almost 7 years ago
- Status changed from New to Ready For Testing
- Assignee set to Marek Hulán
- Pull request https://github.com/theforeman/foreman/pull/4551 added
Updated by Marek Hulán almost 7 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 38b81aed2578c53201f5aa20e56975254d74400f.
Updated by Marek Hulán almost 7 years ago
- translation missing: en.field_release set to 240
Updated by The Foreman Bot almost 7 years ago
- Pull request https://github.com/theforeman/foreman/pull/4601 added
Actions