Project

General

Profile

Actions
Copy link

Bug #19448

closed

After marking discovered hosts notification as read, new discovered host don't create notification

Added by Tomer Brisker almost 7 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Dominik Matoulek
Category:
Discovery plugin
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman_discovery/pull/528
Fixed in Releases:
Discovery Plugin 16.0
Found in Releases:
Red Hat JIRA:

Related issues 1 (0 open — 1 closed)

Blocked by Foreman - Bug #21541: Notifications should have an option to mark all as unreadClosedTomer Brisker11/01/2017Actions
Actions
Copy link
 #1

Updated by Ohad Levy almost 7 years ago

  • Status changed from New to Feedback

for the record, it does update the expiry ts of the notification. I'm in mixed feelings if we should update the read or not?

Actions
Copy link
 #2

Updated by Tomer Brisker almost 7 years ago

IMHO think we should - if you marked discovered hosts as read, then a new host gets discovered, you'd want to get notified about that.

Actions
Copy link
 #3

Updated by Marek Hulán almost 7 years ago

  • Status changed from Feedback to New
  • Target version changed from Discovery Plugin 9.1.0 to Discovery Plugin 12.0.0

I'm reopening this, I think people should be notified about newly discovered hosts even if they marked notification about some discovered hosts previously as read. If people are generally not interested in some kind of notification, is there a way to disable it? Something like "do not notify me in future?". Since 9.1.0 was released already, I'm resetting the target version.

Actions
Copy link
 #4

Updated by Ohad Levy over 6 years ago

if there is a common understanding this should happen for all kind of notifications, you might need to change it in core:
https://github.com/theforeman/foreman/blob/develop/app/models/notification_blueprint.rb#L20

Actions
Copy link
 #5

Updated by The Foreman Bot over 6 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Tomer Brisker
  • Pull request https://github.com/theforeman/foreman_discovery/pull/377 added
Actions
Copy link
 #6

Updated by Tomer Brisker over 6 years ago

  • Blocked by Bug #21541: Notifications should have an option to mark all as unread added
Actions
Copy link
 #7

Updated by Lukas Zapletal almost 6 years ago

  • Target version deleted (Discovery Plugin 12.0.0)
Actions
Copy link
 #8

Updated by The Foreman Bot about 3 years ago

  • Pull request https://github.com/theforeman/foreman_discovery/pull/528 added
Actions
Copy link
 #9

Updated by Tomer Brisker about 3 years ago

  • Assignee changed from Tomer Brisker to Dominik Matoulek
Actions
Copy link
 #10

Updated by Marek Hulán about 3 years ago

  • Pull request deleted (https://github.com/theforeman/foreman_discovery/pull/377)

Unlinking closed PR, it will be still referenced in history

Actions
Copy link
 #11

Updated by The Foreman Bot almost 3 years ago

  • Fixed in Releases Discovery Plugin 16.0 added
Actions
Copy link
 #12

Updated by Dominik Matoulek almost 3 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link

Also available in: Atom PDF