Project

General

Profile

Actions

Refactor #19035

closed

Refactor TopbarSweeper to remove rails-observer dependency

Added by Dominic Cleal about 7 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
Rails
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

The rails-observer project is currently incompatible with Rails 5 and higher, and looks unlikely to be made compatible and released in the near future.

The TopbarSweeper uses rails-observer to clear user topbar caches when user/group/role etc. objects are updated from a controller, but this could be refactored into a model concern. The audited gem is also dropping its dependency, so refactoring TopbarSweeper would allow the dependency to be entirely dropped from Foreman (the original intention of #14434).


Related issues 1 (0 open1 closed)

Blocks Foreman - Tracker #15715: Rails 5.0 upgrade tasksResolved07/18/2016

Actions
Actions #1

Updated by Dominic Cleal about 7 years ago

Actions #2

Updated by The Foreman Bot about 7 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4417 added
Actions #3

Updated by Dominic Cleal about 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #4

Updated by Ohad Levy about 7 years ago

  • translation missing: en.field_release set to 209
Actions

Also available in: Atom PDF