Project

General

Profile

Actions

Bug #19017

closed

Use request id instead of session id of tagged logging

Added by Ivan Necas about 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Logging
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

#15863 introduced tagged logging. In the review discussion, it was suggested to use session id
if available. Although it seemed as a good idea at the beginning, it has several disadvanteges:

  1. it treats UI and API requests differently
  2. it makes it impossible to differentiate requests made from the session at the same time (notifications
    is one example, but in general, we should not assume the user is performing on request at a time)
  3. the usability of this as correlation id is questionable, especially with asynchronous actions in place

Related issues 1 (0 open1 closed)

Related to Foreman - Feature #15863: Log request IDs (tagged logging) in production.logClosedDominic Cleal07/27/2016Actions
Actions #1

Updated by The Foreman Bot about 7 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4410 added
Actions #2

Updated by Ivan Necas about 7 years ago

  • Related to Feature #15863: Log request IDs (tagged logging) in production.log added
Actions #3

Updated by Ivan Necas about 7 years ago

  • Status changed from Ready For Testing to Closed
  • Bugzilla link set to 1408420
Actions #4

Updated by Ivan Necas about 7 years ago

  • Subject changed from Use request id instead of session id of lagged logging to Use request id instead of session id of tagged logging
  • Category set to Logging
Actions #5

Updated by Ohad Levy almost 7 years ago

  • translation missing: en.field_release set to 209
Actions #6

Updated by Ivan Necas almost 7 years ago

  • Target version set to 1.12.2
Actions

Also available in: Atom PDF