Project

General

Profile

Actions

Bug #18227

closed

Snippet with variables does not reset @vars after they finish in unsafe mode

Added by Marek Hulán about 7 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Templates
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

If we have a template such as

<%= snippet 'test', :variables => { :var => 'value' }
<%= @var %>

the @var would be set by the template which can cause problems later. This only happens in unsafe mode where we use the same context for each rendering. We need to split local context variables and reset them after this local context is rendered.


Related issues 1 (0 open1 closed)

Related to Foreman - Feature #18143: Snippet macros should support passing variablesClosedMarek Hulán01/18/2017Actions
Actions #1

Updated by Marek Hulán about 7 years ago

  • Related to Feature #18143: Snippet macros should support passing variables added
Actions #2

Updated by The Foreman Bot about 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4222 added
Actions #3

Updated by Marek Hulán about 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #4

Updated by Dominic Cleal about 7 years ago

  • translation missing: en.field_release set to 209
Actions

Also available in: Atom PDF