Project

General

Profile

Actions

Bug #17238

closed

Able to override Smart Variable for non-existent attribute

Added by Ori Rabin over 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Parameters
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1379277

Description of problem:
We can create matcher for Smart Variable for non-existent attribute in CLI which is basically forbidden in UI and is not correct from logic perspective.
Then in UI, attribute type for that matcher is shown as empty value. Smart variable cannot be edited till matcher is deleted

Version-Release number of selected component (if applicable):
6.2.x
6.3.x

How reproducible:
Always

Steps to Reproduce:
Just an example
1. hammer -v -u admin -p changeme --output=csv smart-variable create --default-value="true" --variable="3LNdaiFVwZ" --puppet-class="ntp" --variable-type="boolean"
2. hammer -v -u admin -p changeme --output=csv smart-variable add-override-value --smart-variable-id="113" --value="false" --match="something_is_here=true"
3.

Actual results:
Matcher is added to Smart Variable

Expected results:
Some validation should be performed like we have in UI that will restrict override procedure for non-existent attributes

Additional info:


Related issues 1 (1 open0 closed)

Related to Foreman - Bug #18281: Host class parameter override of smart class parameter unable to save when "fqdn" is not in order listNew01/27/2017Actions
Actions #1

Updated by Ori Rabin over 7 years ago

  • Status changed from New to Assigned
  • Assignee set to Ori Rabin
Actions #2

Updated by The Foreman Bot over 7 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3997 added
Actions #3

Updated by Ivan Necas over 7 years ago

  • Target version set to 1.3.2
Actions #4

Updated by Ori Rabin over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #5

Updated by Dominic Cleal over 7 years ago

  • translation missing: en.field_release set to 189
Actions #6

Updated by Martin Moerch about 7 years ago

  • Related to Bug #18281: Host class parameter override of smart class parameter unable to save when "fqdn" is not in order list added
Actions

Also available in: Atom PDF