Project

General

Profile

Actions

Bug #16564

closed

"Missing frozen string literal comment." rubocop violations on develop

Added by Dominic Cleal over 7 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Tests
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

All files are failing rubocop checks since #16491 with the following error:

app/models/host.rb:1:1: C: Missing frozen string literal comment.
module Host
^

The Style/FrozenStringLiteralComment cop should be disabled or fixed.

There are also failures in config/initializers/secure_headers.rb that aren't passing, probably from when the PR was merged onto develop without re-checking it passed on the previous commit.


Related issues 2 (0 open2 closed)

Related to Foreman - Bug #16491: upgrade rubocop to version 0.42ClosedTomer Brisker09/08/2016Actions
Related to Katello - Bug #16676: "Missing frozen string literal comment." rubocop violationsClosedDavid Davis09/23/2016Actions
Actions #1

Updated by Dominic Cleal over 7 years ago

  • Related to Bug #16491: upgrade rubocop to version 0.42 added
Actions #2

Updated by Tomer Brisker over 7 years ago

  • Status changed from New to Assigned
  • Assignee set to Tomer Brisker
Actions #3

Updated by The Foreman Bot over 7 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3846 added
Actions #4

Updated by Anonymous over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #5

Updated by Dominic Cleal over 7 years ago

  • translation missing: en.field_release set to 189
Actions #6

Updated by Daniel Lobato Garcia over 7 years ago

  • Target version set to 1.5.2
Actions #7

Updated by David Davis over 7 years ago

  • Related to Bug #16676: "Missing frozen string literal comment." rubocop violations added
Actions

Also available in: Atom PDF