Project

General

Profile

Actions

Bug #16439

closed

Don't fail rebuild if DNS record is already ok

Added by Guido Günther over 7 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Category:
Orchestration
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

The attached PR changes the logic when rebuilding DNS records so that we don't fail if there's no update necessary or the record is nil. Currently we just report an error without any further explanation although everything is o.k. because the "unless" makes us return nil instead of true.

Actions #1

Updated by The Foreman Bot over 7 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Guido Günther
  • Pull request https://github.com/theforeman/foreman/pull/3812 added
Actions #2

Updated by Guido Günther over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #3

Updated by Dominic Cleal over 7 years ago

  • translation missing: en.field_release set to 181
Actions #4

Updated by Dominic Cleal over 7 years ago

  • translation missing: en.field_release changed from 181 to 160

Not applicable to 1.12-stable.

Actions

Also available in: Atom PDF